Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] - Deprecate excluding ML from base privileges #115445

Merged
merged 18 commits into from
Oct 20, 2021
Merged

[7.x] - Deprecate excluding ML from base privileges #115445

merged 18 commits into from
Oct 20, 2021

Conversation

legrego
Copy link
Member

@legrego legrego commented Oct 18, 2021 •
edited
Loading

Summary

Adds upgrade assistance to inform when custom roles exist which will grant access to Machine Learning features in 8.0

image

@legrego
Copy link
Member Author

legrego commented Oct 19, 2021

@elasticmachine merge upstream

@legrego legrego requested a review from jportner October 19, 2021 13:47
@legrego
Copy link
Member Author

legrego commented Oct 19, 2021

@jportner this is ready for preliminary review. I'm fighting my local environment to get screenshots, but I'll post them once they're ready. I know the wording needs to change, but the rest of the changes are ready for a first round

@jportner jportner mentioned this pull request Oct 19, 2021
Closed
@legrego legrego marked this pull request as ready for review October 19, 2021 16:59
jportner
jportner reviewed Oct 19, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, a few minor nits and some suggestions for copy changes below.

With those suggestions applied, the warning looks like this:

image

x-pack/plugins/security/server/deprecations/ml_privileges.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/deprecations/ml_privileges.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/deprecations/ml_privileges.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/deprecations/ml_privileges.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/deprecations/ml_privileges.ts Show resolved Hide resolved
x-pack/plugins/security/server/deprecations/ml_privileges.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/deprecations/ml_privileges.ts Outdated Show resolved Hide resolved
legrego and others added 3 commits October 19, 2021 15:12
@legrego @jportner
Apply suggestions from code review
2f9524b 
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
@legrego
update tests
fea10e9
@legrego
Merge branch '7.x' of github.com:elastic/kibana into security/ml-priv…
97a8524 
…ileges-deprecation
@legrego legrego added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v7.16.0 Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Oct 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego
Copy link
Member Author

legrego commented Oct 19, 2021

@elasticmachine merge upstream

@legrego
Copy link
Member Author

legrego commented Oct 20, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner
Copy link
Contributor

@elasticmachine merge upstream

@jportner jportner enabled auto-merge (squash) October 20, 2021 03:39
@jportner
Copy link
Contributor

@elasticmachine merge upstream

@legrego
Copy link
Member Author

legrego commented Oct 20, 2021

@elasticmachine merge upstream

@legrego
Copy link
Member Author

legrego commented Oct 20, 2021

@elasticmachine merge upstream

@tylersmalley tylersmalley deleted the branch elastic:7.16 October 20, 2021 16:09
auto-merge was automatically disabled October 20, 2021 16:09

Pull request was closed

@tylersmalley tylersmalley reopened this Oct 20, 2021
@legrego
Copy link
Member Author

legrego commented Oct 20, 2021

@elasticmachine merge upstream

@legrego legrego enabled auto-merge (squash) October 20, 2021 18:35
@legrego legrego merged commit 6f34003 into elastic:7.16 Oct 20, 2021
@kibanamachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [18a137c]

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego deleted the security/ml-privileges-deprecation branch October 21, 2021 10:59
@sakurai-youhei
Copy link
Member

linking #115444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner left review comments

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting buildkite-ci release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@legrego @elasticmachine @kibanamachine @jportner @sakurai-youhei @tylersmalley