[uptime] Adjust the theme colors for uptime monitors browser screenshot labels. #115543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
…and alignment for timestamp screenshot popup over footer. elastic#96122
|
@elasticmachine merge upstream |
shahzad31
reviewed
Oct 21, 2021
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
awahab07
added
release_note:fix
v7.16.0
v8.0.0
auto-backport
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
approved these changes
Oct 21, 2021
...ins/uptime/public/components/monitor/ping_list/columns/ping_timestamp/step_image_caption.tsx
Show resolved
Hide resolved
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 21, 2021
…ot labels. (elastic#115543) * Add useBreakpoints reactive hook for uptime. Adjusted color/contrast and alignment for timestamp screenshot popup footer. elastic#96122
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
shivindera
pushed a commit
to shivindera/kibana
that referenced
this pull request
Oct 25, 2021
…ot labels. (elastic#115543) * Add useBreakpoints reactive hook for uptime. Adjusted color/contrast and alignment for timestamp screenshot popup footer. elastic#96122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes up the text color contrast issue (reported in #96122) and other small alignment adjustments, on the footer of journey step screenshot popover in Observability -> Uptime -> (Browser) Monitor.
Before
After
Checklist
Delete any items that are not applicable to this PR.
Documentation was added for features that require explanation or tutorialsAny UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listThis renders correctly on smaller devices using a responsive layout. (You can test this in your browser)For maintainers