Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename getApmHref to getLegacyApmHref #115689

Merged
merged 5 commits into from
Oct 26, 2021
Merged

chore: rename getApmHref to getLegacyApmHref #115689

merged 5 commits into from
Oct 26, 2021

Conversation

luckened
Copy link
Contributor

@luckened luckened commented Oct 20, 2021 •
edited
Loading

Summary

This addresses part of #115161, let me know if i missed something

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@luckened luckened requested review from a team as code owners October 20, 2021 00:06
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 20, 2021
@cla-checker-service
Copy link

cla-checker-service bot commented Oct 20, 2021 •
edited
Loading

💚 CLA has been signed

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

sorenlouv
sorenlouv approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@sorenlouv sorenlouv added v7.16.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes labels Oct 20, 2021
@sorenlouv
Copy link
Member

retest

@sorenlouv
Copy link
Member

@luckened can you please sign contributor agreement?

@sorenlouv sorenlouv closed this Oct 20, 2021
@sorenlouv sorenlouv reopened this Oct 20, 2021
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 20, 2021 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

shahzad31
shahzad31 approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM

You need to fix liniting issue with the code

try running node scripts/eslint.js --fix

@luckened
Copy link
Contributor Author

lint fixed

@sorenlouv
Copy link
Member

Thanks! Just waiting for CI to pass, then I'll merge.

@sorenlouv
Copy link
Member

@elasticmachine merge upstream

@sorenlouv sorenlouv closed this Oct 21, 2021
@sorenlouv sorenlouv reopened this Oct 21, 2021
@sorenlouv
Copy link
Member

jenkins test this please

@sorenlouv
Copy link
Member

jenkins run the tests

@sorenlouv
Copy link
Member

@elasticmachine merge upstream

@sorenlouv sorenlouv removed the v7.16.0 label Oct 23, 2021
@sorenlouv sorenlouv self-assigned this Oct 23, 2021
@sorenlouv
Copy link
Member

Buildkite, test this

@sorenlouv
Copy link
Member

@elasticmachine run elasticsearch-ci/docs

@sorenlouv
Copy link
Member

@elasticmachine merge upstream

@sorenlouv sorenlouv enabled auto-merge (squash) October 25, 2021 23:20
@sorenlouv
Copy link
Member

@elasticmachine run elasticsearch-ci/docs

@sorenlouv
Copy link
Member

Buildkite, test this

@sorenlouv sorenlouv added backport:skip This commit does not require backporting and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Oct 25, 2021
@sorenlouv
Copy link
Member

Buildkite, test this

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sqren

@sorenlouv sorenlouv merged commit 8d195db into elastic:master Oct 26, 2021
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 26, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/poc…
446dc6e 
…-migrate-away-from-injected-css-js

* 'master' of github.com:elastic/kibana: (347 commits)
  [Upgrade Assistant] Disable UI by default in 8.0 (elastic#115782)
  [Uptime] Added permission for new tls alert (elastic#116107)
  [APM] Optimize synthtrace (elastic#116091)
  Fix ux/apm inspector panel (elastic#116188)
  [RAC]: add experimental badge to alerts (elastic#116090)
  Unskip jest handled promise rejections (elastic#116021)
  [Lens] Improve tick placement for binary formatter (elastic#116158)
  chore: rename getApmHref to getLegacyApmHref (elastic#115689)
  [Security Solution] Validate ipv4/CIDR with format x.x.x.x/xx (elastic#116127)
  [Fleet] Use data stream name in query to get data stream info (elastic#115805)
  [Uptime] TLS and TLS legacy alert translation mismatch (elastic#116113)
  New field for integrations field (elastic#116175)
  Set required to false until the input is not visited (elastic#116099)
  Enable interactive setup by default (elastic#116141)
  Add not ready response to interactive setup (elastic#116138)
  Hide or button if needed (elastic#116124)
  [ML] Adding datafeed api tests (elastic#116133)
  Add page title to index advanced page (elastic#116134)
  chore: rename functions in aggregated_transactions helper  (elastic#116001)
  Fix bug where number rendered as date (elastic#116224)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/lib/screenshots/observable.ts
#	x-pack/plugins/reporting/server/lib/screenshots/open_url.ts
@dannycroft dannycroft mentioned this pull request Nov 19, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees

@sorenlouv sorenlouv

Labels
backport:skip This commit does not require backporting 💝community release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luckened @kibanamachine @elasticmachine @sorenlouv @shahzad31