Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ILM] Removed freeze action from Cold phase #116160

Merged
merged 3 commits into from
Oct 26, 2021

Conversation

yuliacech
Copy link
Contributor

@yuliacech yuliacech commented Oct 25, 2021

Fixes #103335

Summary

  • Removed the freeze action from ILM (cold phase)
  • added a clean up to the form serializer to remove freeze action from any policies that still specify it
  • deleted freeze from the Console autocomplete.

How to test

  1. Create an ILM policy with freeze action via Dev Tools
PUT _ilm/policy/test
{
  "policy": {
    "phases": {
      "hot": {
        "min_age": "0ms",
        "actions": {
          "rollover": {
            "max_age": "30d",
            "max_primary_shard_size": "50gb"
          }
        }
      },
      "cold": {
        "min_age": "30d",
        "actions": {
          "freeze": {}
        }
      }
    }
  }
}
  1. Check that the freeze action is not displayed in the cold phase
  2. Check that the freeze action is not displayed in the request flyout
  3. After saving the policy in the UI, check that it doesn't have freeze action defined anymore
GET _ilm/policy/test

Release Note

Since ILM freeze action is a no-op, it was also removed from Index Lifecycle Management.

…ializer, deleted freeze from the Console autocomplete
@yuliacech yuliacech added release_note:fix Feature:ILM v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Oct 25, 2021
@yuliacech yuliacech requested a review from a team as a code owner October 25, 2021 15:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@yuliacech
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #11 / detection engine api security and spaces enabled Detection exceptions data types and operators Rule exception operators for data type float "is not in list" operator working against float values in the data set will return 2 results if we have a list that excludes 2 float

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
indexLifecycleManagement 214 213 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexLifecycleManagement 157.6KB 156.4KB -1.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
indexLifecycleManagement 28.2KB 28.1KB -115.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, code LGTM!

@yuliacech yuliacech merged commit 4b9c3da into elastic:master Oct 26, 2021
@yuliacech yuliacech added the backport:skip This commit does not require backporting label Oct 26, 2021
@yuliacech yuliacech deleted the ilm_remove_freeze branch November 9, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ILM release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ILM] Freeze action deprecation
4 participants