Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Fix Flaky Tests #117402

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Conversation

crob611
Copy link
Contributor

@crob611 crob611 commented Nov 3, 2021

Unskips a flaky set of tests in dashboard_security.

Flaky test runner results, could not reproduce the flakiness. https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/227

Closes #116881

@crob611
Copy link
Contributor Author

crob611 commented Nov 22, 2021

@elasticmachine merge upstream

@crob611 crob611 marked this pull request as ready for review November 22, 2021 20:01
@crob611 crob611 added Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Nov 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@crob611 crob611 added release_note:skip Skip the PR/issue when compiling release notes v8.1.0 review labels Nov 22, 2021
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50 runs, 0 failures? Nice!

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crob611 crob611 merged commit e165373 into elastic:main Nov 23, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 23, 2021
crob611 added a commit that referenced this pull request Nov 23, 2021
crob611 pushed a commit that referenced this pull request Nov 24, 2021
crob611 pushed a commit that referenced this pull request Nov 25, 2021
vitaliidm pushed a commit to vitaliidm/kibana that referenced this pull request Nov 25, 2021
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 26, 2022
kibanamachine added a commit that referenced this pull request Jan 26, 2022
(cherry picked from commit 8cbf57a)

Co-authored-by: Corey Robertson <corey.robertson@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.1.0
Projects
None yet
5 participants