Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add levels to rule registry deprecations #118363

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Add levels to rule registry deprecations #118363

merged 2 commits into from
Nov 15, 2021

Conversation

ersin-erdal
Copy link
Contributor

@ersin-erdal ersin-erdal commented Nov 11, 2021 •
edited
Loading

Summary

Fixes #118332

With this PR, levels for deprecations are explicitly set.

Note: The PR will be merged to 7.16

@ersin-erdal ersin-erdal added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" release_note:deprecation Theme: rac label obsolete v7.16.0 labels Nov 11, 2021
@ersin-erdal ersin-erdal marked this pull request as ready for review November 11, 2021 18:25
@mgiota mgiota self-requested a review November 11, 2021 18:49
mgiota
mgiota approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ersin-erdal
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Nov 15, 2021
@ersin-erdal ersin-erdal merged commit 34bef35 into elastic:7.16 Nov 15, 2021
@ersin-erdal ersin-erdal deleted the 118332-add-levels-to-deprecations branch November 15, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgiota mgiota mgiota approved these changes

Assignees
No one assigned
Labels
release_note:deprecation Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Theme: rac label obsolete v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ersin-erdal @kibana-ci @mgiota @kibanamachine