[Dashboard][Saved Object Tagging] Fix Duplicating Tags #119079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomThomson
added
Feature:Dashboard
crob611
approved these changes
Nov 18, 2021
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
flash1293
approved these changes
Nov 19, 2021
pgayvallet
approved these changes
Nov 19, 2021
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Nov 19, 2021
Fix duplicating tags after importing from 7.12
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Nov 19, 2021
Fix duplicating tags after importing from 7.12
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Nov 19, 2021
Fix duplicating tags after importing from 7.12 # Conflicts: # x-pack/plugins/lens/common/embeddable_factory/index.ts
ThomThomson
added a commit
that referenced
this pull request
Nov 19, 2021
ThomThomson
added a commit
that referenced
this pull request
Nov 19, 2021
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Nov 20, 2021
Fix duplicating tags after importing from 7.12
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
Fix duplicating tags after importing from 7.12
KOTungseth
added a commit
to KOTungseth/kibana
that referenced
this pull request
Nov 29, 2021
KOTungseth
added a commit
that referenced
this pull request
Dec 6, 2021
* [DOCS] Adds 7.16.0 release notes * Updates aggregation-based link * Updates aggregation-based link * Updates aggregation-based link * Updates aggregation-based link * Adds #119079 to bug fixes * Updates aggregation-based link * Link fix * Update docs/CHANGELOG.asciidoc Co-authored-by: Greg Back <1045796+gtback@users.noreply.github.com> * Fixes breaking changes links * Adds Osquery breaking change * Links * Edits ML PR list * More ML edits * Updates with review comments * Removes #111676 * Update docs/CHANGELOG.asciidoc Co-authored-by: DeDe Morton <dede.morton@elastic.co> * Update docs/CHANGELOG.asciidoc Co-authored-by: DeDe Morton <dede.morton@elastic.co> * Update docs/CHANGELOG.asciidoc Co-authored-by: DeDe Morton <dede.morton@elastic.co> * Update docs/CHANGELOG.asciidoc Co-authored-by: DeDe Morton <dede.morton@elastic.co> * Update docs/CHANGELOG.asciidoc Co-authored-by: DeDe Morton <dede.morton@elastic.co> * Observability review comments * Update docs/CHANGELOG.asciidoc Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> * Update docs/CHANGELOG.asciidoc Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> * Update docs/CHANGELOG.asciidoc Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> * Update docs/CHANGELOG.asciidoc Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> * Fixes deprecation link Co-authored-by: Greg Back <1045796+gtback@users.noreply.github.com> Co-authored-by: lcawl <lcawley@elastic.co> Co-authored-by: DeDe Morton <dede.morton@elastic.co> Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
gbamparop
pushed a commit
to gbamparop/kibana
that referenced
this pull request
Jan 12, 2022
Fix duplicating tags after importing from 7.12
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #118796
What is this bug?
References from by Value Visualizations should be extracted into the dashboard saved object in order for exporting to get the correct references. In 7.13.0 a system was added which prefixes each reference with the panel ID it came from, so that it can be matched up with the proper panel.
In the dashboard inject function, references are filtered for each panel by reading the panel id from the prefix. As a fallback, if no references are found matching that panel, all references from the dashboard are passed to the inject function for the associated embeddable type.
This fallback assumes that the inject function for the embeddable type is capable of determining which references are relevant to it, and only injecting those references. Unfortunately, the Lens inject function would copy over all references it was given.
Because by value Lens Panels existed in 7.12 without the prefixing system of subsequent versions, importing a dashboard with a by value Lens from 7.12.1 into a later version resulted in every reference from the dashboard existing in every lens panel. This included any tag references on the dashboard.
When extracting these references for saving, every lens panel would add its own version of the tag, prefixed with its embeddable id. Additionally, the tag extract system wasn't de-duping tags, because theoretically there should never be duplicates. This all resulted in an addition of a number of tags directly relating to the number of by value Lens Panels in the dashboard every time the dashboard was saved.
What is the fix?
Firstly, the Lens inject function now uses its own internal references to match names on any references given to it during inject. This way, only relevant references are injected into the Lens panels. This stops the tags from duplicating, and stops the entire problem in its tracks when a dashboard is imported or migrated from 7.12.1.
Unfortunately, that fix cannot clean up any dashboards which have already suffered from the duplication problem, so a quick de-duping step was added to the tags extract function. Additionally, the dashboard extract function filters out any tags which mistakenly got added into the panel references.