Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - add retry to Fleet package install and removal #120076

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Dec 1, 2021

Summary

This PR stabilizes the module test setup and teardown by adding retries to the Fleet package install and removal service methods.

We've seen some short-living connection issues to the package repository during test execution, which should be fixed by the retry.

Closes #102282

@pheyos pheyos self-assigned this Dec 1, 2021
@pheyos pheyos requested a review from a team as a code owner December 1, 2021 10:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos
Copy link
Member Author

pheyos commented Dec 1, 2021

Checking test stability in a flaky test runner job ... no failure in 50 runs ✔️

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos added the auto-backport Deprecated - use backport:version if exact versions are needed label Dec 1, 2021
@pheyos pheyos merged commit 7ddc136 into elastic:main Dec 1, 2021
@pheyos pheyos deleted the stabilize_fleet_package_handling branch December 1, 2021 16:57
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 1, 2021
elastic#120076)

This PR stabilizes the module test setup and teardown by adding retries to the Fleet package install and removal service methods.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 1, 2021
elastic#120076)

This PR stabilizes the module test setup and teardown by adding retries to the Fleet package install and removal service methods.
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0
7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Dec 1, 2021
#120076) (#120130)

This PR stabilizes the module test setup and teardown by adding retries to the Fleet package install and removal service methods.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
kibanamachine added a commit that referenced this pull request Dec 1, 2021
#120076) (#120132)

This PR stabilizes the module test setup and teardown by adding retries to the Fleet package install and removal service methods.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
elastic#120076)

This PR stabilizes the module test setup and teardown by adding retries to the Fleet package install and removal service methods.
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
elastic#120076)

This PR stabilizes the module test setup and teardown by adding retries to the Fleet package install and removal service methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes test-api-integration v7.16.0 v8.0.0 v8.1.0
Projects
None yet
5 participants