Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Add kibana-verification-tool and CLI main page #120836

Merged
merged 2 commits into from
Dec 9, 2021
Merged

[DOCS] Add kibana-verification-tool and CLI main page #120836

merged 2 commits into from
Dec 9, 2021

Conversation

lockewritesdocs
Copy link
Contributor

@lockewritesdocs lockewritesdocs commented Dec 8, 2021 •
edited
Loading

Adds a new page for the kibana-verification-tool and a top-level page for CLI tools.

Preview link: https://kibana_120836.docs-preview.app.elstc.co/guide/en/kibana/master/kibana-verification-code.html

@lockewritesdocs lockewritesdocs added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes docs auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Dec 8, 2021
@lockewritesdocs lockewritesdocs self-assigned this Dec 8, 2021
@lockewritesdocs lockewritesdocs mentioned this pull request Dec 8, 2021
Closed
thomheymann
thomheymann reviewed Dec 8, 2021
View reviewed changes
Copy link
Contributor

@thomheymann thomheymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for putting this together.

Couple minor comments below.

docs/user/commands/kibana-verification-code.asciidoc Outdated Show resolved Hide resolved
docs/user/commands/kibana-verification-code.asciidoc Outdated Show resolved Hide resolved
docs/user/commands/kibana-verification-code.asciidoc Outdated Show resolved Hide resolved
docs/user/commands/kibana-verification-code.asciidoc Outdated Show resolved Hide resolved
@thomheymann thomheymann added the Feature:Security/Interactive Setup Platform Security - Interactive setup mode label Dec 9, 2021
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lockewritesdocs

@lockewritesdocs
Copy link
Contributor Author

Thanks for the review @thomheymann! I addressed your comments in 1b3203b.

thomheymann
thomheymann approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@thomheymann thomheymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gchaps
gchaps approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lockewritesdocs lockewritesdocs merged commit 2660e14 into elastic:main Dec 9, 2021
@lockewritesdocs lockewritesdocs deleted the docs__add-verification-code-tool branch December 9, 2021 16:57
@lockewritesdocs lockewritesdocs mentioned this pull request Dec 9, 2021
Closed
31 tasks
@kibanamachine kibanamachine mentioned this pull request Dec 9, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 9, 2021
@kibanamachine
[DOCS] Add kibana-verification-tool and CLI main page (elastic#120836)
c04c4bc 
* [DOCS] Add kibana-verification-tool and CLI main page

* Change wording from generating to retrieving
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Dec 9, 2021
@kibanamachine
[DOCS] Add kibana-verification-tool and CLI main page (#120836) (#120970
8da7e92 
)

* [DOCS] Add kibana-verification-tool and CLI main page

* Change wording from generating to retrieving

Co-authored-by: Adam Locke <adam.locke@elastic.co>
@jportner jportner mentioned this pull request Dec 9, 2021
Open
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@TinLe
[DOCS] Add kibana-verification-tool and CLI main page (elastic#120836)
60760c1 
* [DOCS] Add kibana-verification-tool and CLI main page

* Change wording from generating to retrieving
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
@gbamparop
[DOCS] Add kibana-verification-tool and CLI main page (elastic#120836)
b3b68eb 
* [DOCS] Add kibana-verification-tool and CLI main page

* Change wording from generating to retrieving
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomheymann thomheymann thomheymann approved these changes

@gchaps gchaps gchaps approved these changes

@legrego legrego Awaiting requested review from legrego

Assignees

@lockewritesdocs lockewritesdocs

Labels
auto-backport Deprecated - use backport:version if exact versions are needed docs Feature:Security/Interactive Setup Platform Security - Interactive setup mode release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lockewritesdocs @kibana-ci @kibanamachine @thomheymann @gchaps