[Fleet] Move to ISavedObjectsRepository for Saved Object access

[hop-dev]

Summary

As of #120517 we no longer use the functionality of the spaces or security wrapper in the SavedObjectsClient, this means that we are able to move to using the ISavedObjectsRepository interface for accessing saved objects across the board.

This offers two main benefits:

• simplify our access to saved objects e.g there is now no distinction between inernalSOClient and soClient (all our access is now "internal")
• makes our API more explicit to dependent plugins, for example before we had no way of enforcing that a caller provided an "internal" client, by exposing ISavedObjectsRepository we now enforce this.

A high level list of the changes I have made:

• Change SavedObjectsClientContract type to ISavedObjectsRepository
• Modify the calling plugins to supply ISavedObjectsRepository to fleet APIs
• Rename all of our soClient savedObjectsClient variable names to "repo" variable names to be more explicit

[joshdover]

Looking great, thanks for doing this cleanup. It simplifies what we need to think about and eliminates several potential bugs for consumers of Fleet's plugin APIs

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[elasticmachine]

Pinging @elastic/apm-ui (Team:apm)

[kibana-ci]

💔 Build Failed

• Buildkite Build
• Commit: e2f9ed6
• Interpreting CI Failures
• Storybooks Preview
• Webpack Bundle Analyzer

Failed CI Steps

• Jest Tests #5
• Checks
• Osquery Cypress Tests

Test Failures

• [job] [logs] Jest Tests #5 / PackageService asInternalUser calls ensureInstalledPackage and returns results
• [job] [logs] Jest Tests #5 / PackageService asInternalUser calls getInstallation and returns results
• [job] [logs] Jest Tests #5 / PackageService asScoped with required privileges calls ensureInstalledPackage and returns results
• [job] [logs] Jest Tests #5 / PackageService asScoped with required privileges calls getInstallation and returns results

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id	before	after	diff
apm	15	14	-1
securitySolution	67	66	-1
uptime	5	4	-1
total			-3

ESLint disabled line counts

id	before	after	diff
apm	86	83	-3
fleet	40	38	-2
uptime	48	42	-6
total			-11

References to deprecated APIs

id	before	after	diff
fleet	14	10	-4

Total ESLint disabled count

id	before	after	diff
apm	101	97	-4
fleet	48	46	-2
securitySolution	515	514	-1
uptime	53	46	-7
total			-14

History

• 💔 Build #21798 failed 0475f3f
• 💔 Build #21055 failed 2949c49
• 💔 Build #21016 failed 8539406
• 💔 Build #21006 failed 01f6ed2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev