Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adds test for asTransactionRate method #122072

Merged
merged 4 commits into from
Jan 4, 2022
Merged

chore: Adds test for asTransactionRate method #122072

merged 4 commits into from
Jan 4, 2022

Conversation

claudiopro
Copy link
Contributor

Summary

This wee PR adds test coverage for the method asTransactionRate from the observability duration formatters module.

Checklist

@claudiopro claudiopro added chore v8.1.0 release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" auto-backport Deprecated - use backport:version if exact versions are needed labels Dec 28, 2021
@claudiopro claudiopro requested review from a team December 28, 2021 11:47
@claudiopro claudiopro enabled auto-merge (squash) December 28, 2021 11:55
@claudiopro
Copy link
Contributor Author

I addressed your review feedback @estermv , please take another look.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

estermv
estermv approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@estermv estermv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@claudiopro claudiopro merged commit 3de247b into elastic:main Jan 4, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 4, 2022
@kibanamachine
Copy link
Contributor

💔 Backport failed

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 122072

@claudiopro claudiopro deleted the chore_duration_formatters_coverage branch January 4, 2022 15:34
@claudiopro claudiopro mentioned this pull request Jan 4, 2022
Merged
1 task
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
@claudiopro @gbamparop
Adds test for asTransactionRate method (elastic#122072)
b61c0dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estermv estermv estermv approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@claudiopro @kibana-ci @kibanamachine @estermv