[Security Solution][Investigations] Fixes rendering issue of last element of a task list when empty #122242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmonschke
added
bug
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @janmonschke |
michaelolo24
approved these changes
Jan 4, 2022
janmonschke
deleted the
secutiry/fix-glitch-with-last-element-of-task-list
branch
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 4, 2022
…ment of a task list when empty (elastic#122242) * fix: fixes the issue where the last element of a task list would not render properly * test: update test
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
gbamparop
pushed a commit
to gbamparop/kibana
that referenced
this pull request
Jan 12, 2022
…ment of a task list when empty (elastic#122242) * fix: fixes the issue where the last element of a task list would not render properly * test: update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#121986 describes an issue where the last element of a task list does not render properly.
I compared the implementation of the note editor with the one of the comment editor of the cases plugin. The one significant difference I saw was that in the timeline comment editor we trim the note's content. Removing the triming fixes the issue. It should be noted that the original issue only occurs for empty tasks.
Screen.Recording.2022-01-04.at.12.34.10.mov
Checklist