Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maps] fix x-pack/test/functional/apps/maps/documents_source/top_hits.js test #122276

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 4, 2022

fixes #121363

Screen shot below shows failure in CI. Notice how "documents per entity" input is not set to 3, but instead set to 23. This is causing the test to fail. Added logic to retry setting input if its not set to 3.

top_hits_size

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v7.17.0 labels Jan 4, 2022
@nreese nreese requested a review from a team as a code owner January 4, 2022 16:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm when green, code review

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 6273dcb into elastic:main Jan 4, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 4, 2022
….js test (elastic#122276)

* [maps] fix x-pack/test/functional/apps/maps/documents_source/top_hits·js test

* eslint
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 4, 2022
….js test (elastic#122276)

* [maps] fix x-pack/test/functional/apps/maps/documents_source/top_hits·js test

* eslint
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0
7.17

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jan 4, 2022
….js test (#122276) (#122286)

* [maps] fix x-pack/test/functional/apps/maps/documents_source/top_hits·js test

* eslint

Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
kibanamachine added a commit that referenced this pull request Jan 4, 2022
….js test (#122276) (#122287)

* [maps] fix x-pack/test/functional/apps/maps/documents_source/top_hits·js test

* eslint

Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
….js test (elastic#122276)

* [maps] fix x-pack/test/functional/apps/maps/documents_source/top_hits·js test

* eslint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.17.0 v8.0.0 v8.1.0
Projects
None yet
5 participants