[Dashboard] Pass in title to Charts

[VladLasitsa]

Closes: #105131

Summary

Now we can pass aria labels to elastic charts. We decided to pass title from dashboard panel to chart as aria label for better accessibility.

[VladLasitsa]

@elasticmachine merge upstream

[DianaDerevyankina]

LGTM, tested locally

[elasticmachine]

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

[VladLasitsa]

@elasticmachine merge upstream

[alexwizp]

not sure that I like the idea of mutation args in that way. Am I right that with your changes ariaLabel is in the acceptable arguments for that expression?

I think if we really need to take a description using that way you should:

1. add ariaLabel into expression definition

ariaLabel: {
      types: ['string'],
      help: 'help text,
      required: false,
    },

2. update expression function

 fn(data, args, handlers) {
    return {
      type: 'render',
      as: EXPRESSION_GAUGE_NAME,
      value: {
        data,
        args: {
          ...args,
          ariaLabel:
            args.ariaLabel ??
            handlers.variables?.embeddableTitle ??
            handlers.getExecutionContext?.()?.description,
        },
      },
    };
  },

@flash1293 do you have any thoughts?

[stratoula]

From my point of view we don't want this to be part of the expression. Can we fetch it on the renderer and pass it to the component?

[VladLasitsa]

I see only one possibility to get title it is pass it to handlers.variables or getExecutionContext, but I don't see option how we can fetch it on renderer because ExpressionRenderHandler doesn't include something like this.

[flash1293]

I agree with @alexwizp here - if we use the args to pass it in, we should make it a "real" argument. I don't think it hurts having it as part of the expression interface necessarily - this allows users in Canvas to override it as well.
@ppisljar @crob611 What do you think? Does it make sense to add the ariaLabel argument to all expression function?

[alexwizp]

@VladLasitsa I like how it looks now. LGTM in case of getting approvals from @ppisljar / @crob611

[flash1293]

@elasticmachine merge upstream

[kibanamachine]

merge conflict between base and head

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 1ebf138
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
expressionHeatmap	109	110	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
expressionGauge	8.5KB	8.5KB	+57.0B
expressionHeatmap	15.8KB	15.9KB	+57.0B
expressionPartitionVis	42.4KB	42.5KB	+77.0B
expressionTagcloud	7.6KB	7.7KB	+57.0B
lens	1.0MB	1.0MB	+336.0B
visTypeTimelion	121.4KB	121.4KB	+49.0B
visTypeXy	60.2KB	60.3KB	+71.0B
visualizations	112.3KB	112.5KB	+200.0B
total			+904.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
expressionGauge	9.4KB	9.9KB	+444.0B
expressionHeatmap	13.0KB	13.4KB	+424.0B
expressionPartitionVis	18.8KB	20.1KB	+1.3KB
expressionTagcloud	7.5KB	7.9KB	+451.0B
lens	42.4KB	43.1KB	+721.0B
visTypeTimelion	9.3KB	9.7KB	+373.0B
visTypeXy	42.4KB	42.8KB	+407.0B
total			+4.0KB

Unknown metric groups

API count

id	before	after	diff
expressionHeatmap	113	114	+1

History

• 💚 Build #21804 succeeded 475b83b
• 💔 Build #21787 failed 47c3b44
• 💛 Build #21305 was flaky 041067d
• 💚 Build #20719 succeeded 035b10e
• 💔 Build #20696 failed 7bc5562
• 💚 Build #18001 succeeded 349c80e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

[flash1293]

LGTM, tested on dashboard and Canvas