[Uptime] UI Monitor Management/Synthetics Service e2e tests - add environment variables for service #122552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiqueclarke
commented
Jan 10, 2022
x-pack/plugins/uptime/e2e/config.ts
Outdated
| '--xpack.uptime.unsafe.service.manifestUrl=https://manifest.synthetics.elastic.dev/v1/manifest.json', | ||
| `--xpack.uptime.unsafe.service.username=${process.env.SYNTHETICS_SERVICE_USERNAME}`, | ||
| `--xpack.uptime.unsafe.service.password=${process.env.SYNTHETICS_SERVICE_PASSWORD}`, | ||
| '--xpack.uptime.unsafe.service.hosts=["https://synthetics-service-es.es.us-west2.gcp.elastic-cloud.com:9243"]', |
There was a problem hiding this comment.
Trying to figure out how to manage the es instance so that the service can communicate back with the tests running on CI.
dominiqueclarke
force-pushed
the
feature/uptime-synthetics-service-e2e-tests
branch
from
69157e2
to
4748518
Compare
dominiqueclarke
force-pushed
the
feature/uptime-synthetics-service-e2e-tests
branch
from
4748518
to
f4f8ca4
Compare
dominiqueclarke
commented
Jan 17, 2022
| @@ -10,7 +10,7 @@ import { playwrightRunTests } from './playwright_start'; | |||
|
|
|||
| const { argv } = yargs(process.argv.slice(2)) | |||
| .option('headless', { | |||
| default: true, | |||
| default: false, | |||
There was a problem hiding this comment.
I didn't intend to commit this. Will fix.
dominiqueclarke
added
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
|
@elasticmachine merge upstream |
dominiqueclarke
commented
Jan 18, 2022
shahzad31
reviewed
Jan 18, 2022
| async waitForLoadingToFinish() { | ||
| while (true) { | ||
| if ((await page.$('[data-test-subj=kbnLoadingMessage]')) === null) break; | ||
| await page.waitForTimeout(5 * 1000); |
There was a problem hiding this comment.
i think we should reduce this timeout , WDYT? 5 seconds seems too slow for some requests.
There was a problem hiding this comment.
I think higher timeouts will reduce flakiness, and this isn't outrageously high that I feel it'll add an outrageous amount of time to run the tests.
shahzad31
approved these changes
Jan 18, 2022
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
tylersmalley
approved these changes
Jan 18, 2022
dominiqueclarke
deleted the
feature/uptime-synthetics-service-e2e-tests
branch
ogupte
pushed a commit
to ogupte/kibana
that referenced
this pull request
Jan 28, 2022
…ironment variables for service (elastic#122552) * add environment variables for service * add SYNTHETICS_SERVICE_MANIFEST and basic tests * Update x-pack/plugins/uptime/e2e/playwright_run.ts Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Synthetics agent tests for Uptime Monitor Management.
Running these tests
x-pack/plugins/uptime/scriptsdirectory. Runnode e2e.js --server. Wait for the instance to start upx-pack/plugins/uptime/e2edirectory. Runnode ../../../../scripts/functional_test_runner --config playwright_run.ts