Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Endpoint] Fix endpointAppContextServices use of calculateEndpointAuthz #123494

Merged
merged 1 commit into from
Jan 20, 2022
Merged

[Security Solution][Endpoint] Fix endpointAppContextServices use of calculateEndpointAuthz #123494

merged 1 commit into from
Jan 20, 2022

Conversation

paul-tavares
Copy link
Contributor

Summary

  • ensure that calculateEndpointAuthz() of EndpointAppContextServices is given user roles

Fix merge run condition with two prior PR I merged just seconds apart

@paul-tavares paul-tavares added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Jan 20, 2022
@paul-tavares paul-tavares self-assigned this Jan 20, 2022
@paul-tavares paul-tavares requested a review from a team as a code owner January 20, 2022 18:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@paul-tavares paul-tavares enabled auto-merge (squash) January 20, 2022 18:28
@brianseeders brianseeders enabled auto-merge (squash) January 20, 2022 19:15
@brianseeders brianseeders merged commit 855bfd3 into elastic:main Jan 20, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 20, 2022
@kibanamachine
Copy link
Contributor

💔 Backport failed

The pull request could not be backported due to the following error:
There are no branches to backport to. Aborting.

How to fix

Re-run the backport manually:

node scripts/backport --pr 123494

Questions ?

Please refer to the Backport tool documentation

@paul-tavares paul-tavares deleted the fix/bug-in-endpoint-app-context-services branch January 20, 2022 19:25
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
apm 14 15 +1
securitySolution 67 68 +1
total +2

ESLint disabled line counts

id before after diff
apm 84 87 +3

Total ESLint disabled count

id before after diff
apm 98 102 +4
securitySolution 522 523 +1
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @paul-tavares

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzl pzl pzl approved these changes

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

@joeypoon joeypoon joeypoon approved these changes

@kevinlog kevinlog kevinlog approved these changes

@ashokaditya ashokaditya Awaiting requested review from ashokaditya ashokaditya was automatically assigned from elastic/security-onboarding-and-lifecycle-mgt

@dasansol92 dasansol92 Awaiting requested review from dasansol92 dasansol92 was automatically assigned from elastic/security-onboarding-and-lifecycle-mgt

Assignees

@paul-tavares paul-tavares

Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@paul-tavares @elasticmachine @kibanamachine @kibana-ci @pzl @FrankHassanabad @joeypoon @kevinlog @brianseeders