Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate the pre-7.11 tasks that has no schedule field. #124304

Merged
merged 12 commits into from
Feb 9, 2022
Merged

Migrate the pre-7.11 tasks that has no schedule field. #124304

merged 12 commits into from
Feb 9, 2022

Conversation

ersin-erdal
Copy link
Contributor

fixes: #117593

Summary

Force the pre-7.11 tasks that has no schedule field to be picked up, by setting "attempt" field as 0 and "status" field as idle.

Checklist

@ersin-erdal ersin-erdal added release_note:skip Skip the PR/issue when compiling release notes Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.2.0 labels Feb 1, 2022
@ersin-erdal ersin-erdal marked this pull request as ready for review February 3, 2022 13:07
@ersin-erdal ersin-erdal requested a review from a team as a code owner February 3, 2022 13:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@ymao1 ymao1 mentioned this pull request Feb 4, 2022
Merged
1 task
@ersin-erdal
Copy link
Contributor Author

@elasticmachine merge upstream

ymao1
ymao1 approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some comments about tests

x-pack/plugins/task_manager/server/saved_objects/migrations.test.ts Show resolved Hide resolved
x-pack/plugins/task_manager/server/saved_objects/migrations.test.ts Show resolved Hide resolved
@ersin-erdal
Copy link
Contributor Author

@elasticmachine merge upstream

@mikecote mikecote self-requested a review February 8, 2022 18:50
mikecote
mikecote reviewed Feb 9, 2022
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment so far, but everything else looks good! I was able to see failed tasks start running again, just a question about tasks remaining in running state.

x-pack/plugins/task_manager/server/saved_objects/migrations.ts Outdated Show resolved Hide resolved
@ersin-erdal
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
taskManager 32 33 +1
Unknown metric groups

API count

id before after diff
taskManager 70 71 +1

Unreferenced deprecated APIs

id before after diff
taskManager 0 1 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mikecote
mikecote approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@ersin-erdal ersin-erdal merged commit fcd5641 into elastic:main Feb 9, 2022
@ersin-erdal ersin-erdal deleted the 117593-migrate-tasks-without-schedule branch February 9, 2022 21:14
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 11, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124304 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124304 or prevent reminders by adding the backport:skip label.

@spalger spalger added the backport:skip This commit does not require backporting label Feb 15, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote approved these changes

@ymao1 ymao1 ymao1 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Task Manager release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Alerting] Gracefully restore failed rules from pre-7.11
7 participants
@ersin-erdal @elasticmachine @kibana-ci @kibanamachine @mikecote @ymao1 @spalger