[Fleet] Use package policy version to determine managed policy upgrades #125788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
joshdover
added
the
auto-backport
💛 Build succeeded, but was flakyTest Failures
Metrics [docs]
To update your PR or re-run it, just comment with: cc @joshdover |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 16, 2022
…es (elastic#125788) (cherry picked from commit 3dd2d75)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 16, 2022
…es (elastic#125788) (cherry picked from commit 3dd2d75)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Similar to #125525, this handles another scenario where a package version may no longer be available in the registry. In this case, a prerelease version of a managed package can cause the auto-upgrades for managed package policies to fail during Fleet setup due to the previous prerelease version not being present in the registry or installed in ES any longer.
I changed the decision logic for deciding when to upgrade a managed package policy by removing the fetch of the package from ES storage or the registry which seemed unnecessary since the required information is already present in fetching the installed version of the package and the version information on the package policy itself.
Checklist
Delete any items that are not applicable to this PR.