Fix to sessionview search #128680
Merged
Fix to sessionview search #128680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 23, 2022 12:31
…ch when verbose mode is OFF
…ch when verbose mode is OFF
mitodrummer
added
bug
mitodrummer
commented
Mar 28, 2022
| @@ -94,11 +94,6 @@ export class ProcessImpl implements Process { | |||
| return false; | |||
| } | |||
|
|
|||
| // If the process has no children and has not exec'd (fork only), we hide it. | |||
| if (child.children.length === 0 && !child.hasExec()) { | |||
There was a problem hiding this comment.
removing this as it was added because of a bug in endpoint where entity_id would change btw the fork and exec calls thus creating a bunch of lone forks.
mitodrummer
commented
Mar 28, 2022
|
|
||
| const eTop = processEl.offsetTop; |
There was a problem hiding this comment.
There was a bug in this check where isVisible would return true even if the process was below the fold. The improved code was borrowed from the isVisible hook.
mitodrummer
commented
Mar 28, 2022
| @@ -32,58 +31,6 @@ export const ChildrenProcessesButton = ({ | |||
| ); | |||
| }; | |||
|
|
|||
| export const SessionLeaderButton = ({ | |||
There was a problem hiding this comment.
cleanup from the old 'verbose mode' UX
mitodrummer
added
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds useMemo wrapper on getChildren call in process_tree_node.
Fixed some issues with verbose mode OFF and matching on deeply nested search results.
When searching, regardless of verbose mode setting, if a process matches a search it will be unhidden along with it's lineage (e.g parents up the tree to the root).