[Triggers Actions UI] Fix double registry bug #131239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
academo
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
cnasikas
approved these changes
Apr 29, 2022
XavierM
approved these changes
Apr 29, 2022
YulNaumenko
reviewed
Apr 29, 2022
| @@ -17,6 +17,9 @@ const registerAlertsTableConfiguration = ( | |||
| registry: AlertsTableConfigurationRegistryContract, | |||
| storage: Storage | |||
| ) => { | |||
| if (registry.has(APP_ID)) { | |||
There was a problem hiding this comment.
Do we have the proper unit test for this fix? I think we need to add the test coverage here.
dmlemeshko
pushed a commit
to dmlemeshko/kibana
that referenced
this pull request
May 5, 2022
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug introduced by #130881 when the register is called twice.