Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Rename service groups template titles and links #131381

Merged
merged 4 commits into from
May 4, 2022
Merged

[APM] Rename service groups template titles and links #131381

merged 4 commits into from
May 4, 2022

Conversation

kpatticha
Copy link
Contributor

closes #130960

Screen.Recording.2022-05-03.at.11.42.46.mov

@kpatticha kpatticha requested a review from a team as a code owner May 3, 2022 09:52
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label May 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kpatticha
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB -99.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 31.0KB 31.1KB +81.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

MiriamAparicio
MiriamAparicio approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

@kpatticha kpatticha merged commit dbb4d3c into elastic:main May 4, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 4, 2022
dmlemeshko pushed a commit to dmlemeshko/kibana that referenced this pull request May 5, 2022
@kpatticha @kibanamachine @dmlemeshko
[APM] Rename service groups template titles and links (elastic#131381)
b949593 
* [APM] Update template title for service groups

* [APM] Update link titles in global search

* Fix translations

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kpatticha kpatticha mentioned this pull request May 11, 2022
Merged
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@kpatticha @kibanamachine @kertal
[APM] Rename service groups template titles and links (elastic#131381)
8920ddc 
* [APM] Update template title for service groups

* [APM] Update link titles in global search

* Fix translations

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiriamAparicio MiriamAparicio MiriamAparicio approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:fix Team:APM All issues that need APM UI Team support v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Service groups: When groups are enabled rename the Services routes
5 participants
@kpatticha @elasticmachine @kibana-ci @MiriamAparicio @kibanamachine