[Pie] Run all functional tests for the new implementation #131700
Conversation
| @@ -65,7 +64,6 @@ const LegendToggleComponent = ({ onClick, showLegend, legendPosition }: LegendTo | |||
| defaultMessage: 'Toggle legend', | |||
| })} | |||
| aria-expanded={showLegend} | |||
| aria-controls={legendId} | |||
There was a problem hiding this comment.
ℹ️ This aria property is used with the wrong way (the dashboard a11y tests were also complaining)
| await queryBar.clickQuerySubmitButton(); | ||
| await retry.tryForTime(5000, async () => { | ||
| const headers = await PageObjects.discover.getColumnHeaders(); | ||
| expect(headers.length).to.be(0); | ||
| await pieChart.expectPieSliceCount(0); | ||
| await pieChart.expectEmptyPieChart(); |
There was a problem hiding this comment.
ℹ️ We don't have EC debug state for empty charts so I am testing this scenario with the empty chart container.
stratoula
added
Feature:Pie Chart
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
| @@ -140,6 +144,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { | |||
| await PageObjects.dashboard.gotoDashboardLandingPage(); | |||
| await PageObjects.dashboard.loadSavedDashboard('with filters'); | |||
| await PageObjects.header.waitUntilLoadingHasFinished(); | |||
| await elasticChart.setNewChartUiDebugFlag(true); | |||
| await queryBar.submitQuery(); | |||
There was a problem hiding this comment.
Does the debug flag not decorate the pie slices until after the query has been submitted?
There was a problem hiding this comment.
It needs to be re-rendered (the pie chart) so this is the reason I am submitting the query. If you refresh, the window flag is lost, so you need to do something to re-render it but without refreshing the browser.
…1700) * [Pie] Run all functional tests for the new implementation * Fix CI * Fix tests * More fixes * More test foxes * Fix a11y tests * Further fies * Fix * Further fixes * Final fixes * Fix more pie related tests * Fixes more fixes * Fix dashboard tests * Fix dashboard filtering test * Fix the reporting tests * BWC tests
Summary
I removed the
'visualization:visualize:legacyPieChartsLibrary': true,from the functional tests suite. This means that now all the pie chart tests are using the new implementation (EC).I am testing the old implementation in specific scenarios. These scenarios should be removed when we remove the vislib implementation of the pie.
Checklist