Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs, Alerting] [Space, Time] Add "Explain" functionality to the Alerting Framework [DO NOT MERGE] #131753

Closed

Conversation

Kerry350
Copy link
Contributor

@Kerry350 Kerry350 commented May 6, 2022

⚠️ THIS SHOULD NOT BE MERGED. It is the result of On Week / Space, Time.

Summary

This is a very rough, but functional, implementation of an "Explain" functionality for the Alerting Framework. It is opt-in by solutions.

Original issue: #84417

Details

TODO

explain

Screenshot 2022-05-06 at 18 01 34

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 6, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Default CI Group #11 / detection engine api security and spaces enabled Generating signals from ml anomalies should create 1 alert from ML rule when record meets anomaly_threshold
  • [job] [logs] Default CI Group #11 / detection engine api security and spaces enabled Generating signals from ml anomalies should create 1 alert from ML rule when record meets anomaly_threshold

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
triggersActionsUi 370 372 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
alerting 316 324 +8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 724.3KB 725.8KB +1.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 99.7KB 100.0KB +302.0B
Unknown metric groups

API count

id before after diff
alerting 325 333 +8

ESLint disabled in files

id before after diff
apm 15 14 -1
securitySolution 69 68 -1
synthetics 7 6 -1
total -3

ESLint disabled line counts

id before after diff
apm 92 89 -3
enterpriseSearch 9 7 -2
synthetics 53 47 -6
total -11

Total ESLint disabled count

id before after diff
apm 107 103 -4
enterpriseSearch 9 7 -2
securitySolution 511 510 -1
synthetics 60 53 -7
total -14

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@matschaffer
Copy link
Contributor

This is awesome. I wonder how we could get the UX more aligned with the "inspect" links found in the header of visualizations 🤔

@Kerry350
Copy link
Contributor Author

This is awesome. I wonder how we could get the UX more aligned with the "inspect" links found in the header of visualizations

Thanks Mat. Yeah, the UI / UX received the least amount of love here, it would certainly need some thinking from the design folks, and would likely look completely different to this.

I would secretly love for this to have time to be refined and merged 😅

@matschaffer
Copy link
Contributor

I would secretly love for this to have time to be refined and merged

ahem @smith - we should make this less of a secret ;)

@legrego legrego closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants