-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] fix script_type for monitor management telemetry #131855
[Synthetics] fix script_type for monitor management telemetry #131855
Conversation
804e977
to
5fa8d3e
Compare
Pinging @elastic/uptime (Team:uptime) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Work as expected LGTM !!
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
* synthetics - fix script_type for monitor management telemetry * adjust tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 94b894a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Post FF Testing
|
Summary
Fixes Monitor Management telemetry by adding the appropriate
script_type
to the request body for browser monitors.Testing
The easiest way to test this is to add a console log here
Testing inline monitors
script_type
isinline
(You'll see two events each time)script_type
isinline
script_type
isinline
Testing recorder monitors
script_type
isrecorder
(You'll see two events each time)script_type
isrecorder
script_type
isrecorder
Delete any items that are not applicable to this PR.