Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip flaky Space Selection tests #131905

Merged
merged 2 commits into from
May 11, 2022
Merged

Unskip flaky Space Selection tests #131905

merged 2 commits into from
May 11, 2022

Conversation

legrego
Copy link
Member

@legrego legrego commented May 10, 2022 •
edited
Loading

Leverages the fix from #131835 to unskip several other flaky spaces tests.

Resolves #99581
Resolves #118356
Resolves #118474

Flaky test runner results

200 test executions completed without failures!

@legrego legrego added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.3.0 v7.17.4 labels May 10, 2022
@legrego legrego marked this pull request as ready for review May 10, 2022 14:47
@legrego legrego requested a review from a team as a code owner May 10, 2022 14:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego legrego enabled auto-merge (squash) May 10, 2022 15:35
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

azasypkin
azasypkin approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@legrego legrego merged commit 9949a01 into elastic:main May 11, 2022
kibanamachine pushed a commit that referenced this pull request May 11, 2022
@legrego
Unskip flaky tests (#131905)
4460d2f 
(cherry picked from commit 9949a01)
@kibanamachine kibanamachine mentioned this pull request May 11, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 11, 2022
@kibanamachine @legrego
Unskip flaky tests (#131905) (#132007)
f5ab871 
(cherry picked from commit 9949a01)

Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
@legrego legrego deleted the spaces/flaky-selection-test branch May 11, 2022 12:21
academo pushed a commit to academo/kibana that referenced this pull request May 12, 2022
@legrego
Unskip flaky tests (elastic#131905)
6513efb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.17.4 v8.3.0
Projects
None yet
Milestone
No milestone
5 participants
@legrego @elasticmachine @kibana-ci @kibanamachine @azasypkin