[Screenshotting] Added workaround for webgl driven canvases #131907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
release_note:skip
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
|
Pinging @elastic/kibana-app-services (Team:AppServicesUx) |
jloleysens
added
the
(Deprecated) Feature:Reporting
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
tsullivan
approved these changes
May 10, 2022
tsullivan
reviewed
May 10, 2022
| const img = document.createElement('img'); | ||
| img.src = (thisCanvas as HTMLCanvasElement).toDataURL('image/png'); | ||
| newDiv.appendChild(img); | ||
| thisCanvas.parentNode!.replaceChild(newDiv, thisCanvas); |
There was a problem hiding this comment.
cc @elastic/kibana-gis
for awareness: In print-layout PDF reports, we found a bug in Chromium that forces us to capture a screenshot of the map, and then replace the canvas element with the screenshot, before we take the PDF.
There was a problem hiding this comment.
This applies to lens charts as well, as Lens canvas tags.
academo
pushed a commit
to academo/kibana
that referenced
this pull request
May 12, 2022
…131907) * added workaround for webgl driven canvases * expand comment with link to origin of idea Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TL;DR additional mitigation for potentially getting blank maps in PDFs. Tested with 20 PDFs.
Added a long comment in the code to explain the reasoning behind the change.
Samples
Related