-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] scale marker size by area #131911
[Maps] scale marker size by area #131911
Conversation
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-gis (Team:Geo) |
This is looking great, showing side to side between this PR on the left and current view (8.2.0) on the right, as in the PR description, the size of the smaller points improves. I wonder, and it would go a follow up PR for sure, if we could improve the way the symbol size is communicated in the legend so users understand better the mapping between values and symbol size. This wikipedia example shows a very classic way to display point sizes, but even just showing the actual max/min point sizes in the current legend, maybe adding a midpoint, could already improve a lot. @gvnmagni what do you think? |
I love that idea Jorge, it would help a lot our users understanding the proportion and it will guide then in reading values even without hovering with the cursor 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally on Chrome
* [Maps] scale marker size by area * icon size * clean up * more clean-up * add tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Fixes #131698
This PR updates the maplibre style expression to interpolate over the square root of value instead of value to avoid distorting proportions when styling marker areas.
This has the visual effect of making markers for smaller values larger by reducing the interpolation range.
For example, with a marker size range of [8, 32] and a data range of [0, 100]
Before
After
Notice the larger circles for the values in Alaska