[XY] Add support of `pointseries` input type #131919

VladLasitsa · 2022-05-10T13:39:19Z

Completes part of #127115

Summary

Added pointseries input type as possible to xyVis. As part of this was decided to use accessors from pointseries as xyVis accessors by default so that user can provide xyVis without xAccessor, accessor and splitAccessor when uses pointseries:

x column becomes xAccessor
y column becomes accessor
color becomes splitAccessor

Example:

Features of `pointseries` to be handled by `xyVis` in the future:

size - should be implemented in the follow-up PR to [XY] Mark size configuration. #130361
text - is it going to be implemented? cc @crob611, @flash1293

…to chart_expressions-xy

# Conflicts: # src/plugins/chart_expressions/expression_xy/common/expression_functions/legend_config.ts # x-pack/plugins/lens/public/xy_visualization/visualization.tsx

…to chart_expressions-xy

…_layers' into chart_expressions-xy_support_pointseries

…y_support_pointseries

# Conflicts: # src/plugins/chart_expressions/expression_xy/common/expression_functions/data_layer.ts

elasticmachine · 2022-05-11T07:07:44Z

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

kibana-ci · 2022-05-11T07:20:54Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`expressionXY`	89	90	+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`expressions`	1718	1719	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`expressionXY`	55.9KB	55.5KB	-476.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`expressions`	96.7KB	96.9KB	+192.0B
`expressionXY`	27.8KB	28.6KB	+894.0B
total			+1.1KB

Unknown metric groups

API count

id	before	after	diff
`expressions`	2166	2167	+1

History

💚 Build #43805 succeeded e2a1c46
💔 Build #43736 failed 652e563
💚 Build #43692 succeeded ef645ce

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

Kuznietsov

Code LGTM 👍

flash1293

LGTM from VisEditors side, but someone from the presentation team should take a look as well to make sure everything is working as expected for Canvas.

Side note - I noticed pointseries is not showing up in the autocomplete, is this expected?

ppisljar

lgtm

* added xy plugin. * Added expressionXY limits. * Added xy expression functions to the expression_xy plugin. * Moved xy to a separate plugin. * Small refactoring. * Fixed types. * Fixed import of scss. * Fixed imports. * Added required plugins. * Fixed import * Fixed types. * Changed expression names. * Fixed bugs, caused by the refactoring process. * Fixed lens snapshots. * Removed new line. * Fixed xy_chart tests. * Added lazy loading for xy chart. * Fixed xy chart test. * Fixed broken chart selectors. * Fixed dashboard tests. * dashboard test fixed. * Fixed heatmap vis. * Smokescreen test fixed. * more fixes. * async dashboard tests fixed. * Fixed xy smokescreen tests selectors. * fixed show_underlying_data tests. * Updated snapshots. * updated limits. * Fixed more selectors * Fixed persistent context test. * Fixed some more test at ml. * Fixed types and imports * Fixed handlers.inspectorAdapters.tables.logDatatable * Fixed logDatatable * Translations fixed. * Fixed "Visualize App ... cleans filters and query" test. cleans filters and query * Fixed "lens disable auto-apply tests" test. * Updated dashboard tests. * Fixed translations. * Expression tests fixed. * Cleaned up expression_xy. * cleaned up lens xy_visualization. * fixed more tests. * Fix of tsvb. * Fixed more tests. * Fixed xy chart limits. * Fixed new tests. * Fixed types. * Added extended layers expressions. * Added support of tables at layers. * Fixed tests. * Fixed more tests. * Fixed lens types. * Added tables to layers. * Checks fixed. * updated tests. * Fixed types. * Add support of pointseries input type * Fix checks * First try to fix merge conflicts. * Fixed annotatations. * Fixed types. * Updated snapshots * Fixed tests. * Fixed dependencies. * Fixed i18n. * Moved XY state types to lens. * Fixed more types. * Update src/plugins/chart_expressions/expression_xy/README.md Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com> * [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs' * Removed yConfig from *Layers types * Fixed styles. * Fixed types. * Removed not used utils and styles. * Fixed types and tests. * updated size. * Use `expression` as name for datatable column * Added right behavior, related to the tables, comming from the expression. * Fixed reference lines. * Fixed jsdoc. * Added annotations to layeredXyVIs. * Fixed limits. * Refactored the implementation to be reusable. * Fixed undefined layers. * Fixed empty arrays problems. * Fixed input translations and removed not used arguments. * Fixed missing required args error, and added required to arguments. * Simplified expression configuration. * Added strict to all the expressions. * refactored code, according to the nit. * Moved dataLayer to the separate component. * Fixed jest tests. * Fixed tests. * Refactored dataLayers helpers and xy_chart. * More fixes of the expression Added extendedYConfig for dataLayers. Added yConfig for referenceLineLayers. Fixed undefined id at tooltip. * Fixed tests and snapshots. * Icons at annotations and reference lines are strict. * axis extent validation added. * Added checks to the legend config. * fillOpacity usage validation is added. * Fixed valueLabels argument options. Removed not used. Added validation for usage. * Removed not used tests and imports. * Fixed valueLabels and added migrations. * Fixed type checks. * Added test for the migrations. * Fixed imports. * Fixed types * Fixed i18n checks. # Conflicts: # src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx * Fixed imports and types. * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Update src/plugins/chart_expressions/expression_xy/common/expression_functions/extended_annotation_layer.ts Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com> * Removed extra extends. * Update src/plugins/chart_expressions/expression_xy/common/expression_functions/annotation_layer.ts Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com> * Added guard. * Fixed the code duplication. * Removed table from the annotation layer. * Changed the `convertActiveDataFromIndexesToLayers` location. * Added tests for convertActiveDataFromIndexesToLayers * Reduced the bundle size a little bit. * Reused strings and args. * Refactored expression functions. Added asynchronous behavior. * Fixed tests. * Updated limits. * Updated the limit. * Fixed types. * fixed types. * Turned back layerIds. * Removed convertActiveData from Lens. * Added test to the layerIds generator. * Fixed types. * Fixed problems with resetting of the inspector. * Fixed migrations. * Removed types. * Removed tones of `areFormatted` calculations. * Fixed `isTimeViz` and `isHistogramViz` by replacing filteredLayers with dataLayers. * Removed referenceLineLayers from the `groupAxesByType` fn. * Added validation to the layeredXyVis. * Fixed extent validation. * Removed comments. * Reduced limit. * Added optimizations. * Fixed floatingColumns error. * Fixed types. * Updated limits. * Fix import * Fixed problems with formatting. * Small nit fix. * Fixed limits. Co-authored-by: Yaroslav Kuznietsov <kuznetsov.yaroslav.yk@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>

Kuznietsov and others added 30 commits March 8, 2022 16:08

added xy plugin.

9388bba

Merge branch 'main' into chart_expressions-xy

8df9659

Added expressionXY limits.

ab72728

Merge branch 'chart_expressions-xy' of github.com:Kunzetsov/kibana in…

5747322

…to chart_expressions-xy

Added xy expression functions to the expression_xy plugin.

b4ee9c1

Moved xy to a separate plugin.

400845d

Small refactoring.

b2090f3

Fixed types.

33a06fa

Merge branch 'main' into chart_expressions-xy

d94fa4f

# Conflicts: # src/plugins/chart_expressions/expression_xy/common/expression_functions/legend_config.ts # x-pack/plugins/lens/public/xy_visualization/visualization.tsx

Fixed import of scss.

663e093

Fixed imports.

cbffe77

Added required plugins.

389f933

Fixed import

90aa97a

Fixed types.

1d3a264

Changed expression names.

a78d45d

Fixed bugs, caused by the refactoring process.

35cab91

Merge branch 'main' into chart_expressions-xy

847b3c4

Fixed lens snapshots.

ed7f8ea

Removed new line.

b6daa5d

Merge branch 'chart_expressions-xy' of github.com:Kunzetsov/kibana in…

bda6524

…to chart_expressions-xy

Fixed xy_chart tests.

c8d40fe

Added lazy loading for xy chart.

5fed60c

Fixed xy chart test.

dc195b2

Fixed broken chart selectors.

d39681f

Fixed dashboard tests.

b901d68

dashboard test fixed.

d327dfe

Fixed heatmap vis.

b500961

Smokescreen test fixed.

7a25b74

more fixes.

0004794

async dashboard tests fixed.

fc8c0b3

VladLasitsa and others added 4 commits April 27, 2022 17:12

Merge remote-tracking branch 'Kunzetsov/chart_expressions-xy-extended…

fbf8f23

…_layers' into chart_expressions-xy_support_pointseries

Fix import

21b0e27

Merge remote-tracking branch 'upstream/main' into chart_expressions-x…

204a627

…y_support_pointseries

Merge branch 'main' into chart_expressions-xy_support_pointseries

ef645ce

# Conflicts: # src/plugins/chart_expressions/expression_xy/common/expression_functions/data_layer.ts

VladLasitsa mentioned this pull request May 10, 2022

[XY] Expression unification #127115

Closed

31 tasks

VladLasitsa requested a review from Kuznietsov May 10, 2022 13:48

VladLasitsa self-assigned this May 10, 2022

VladLasitsa added Feature:XYAxis XY-Axis charts (bar, area, line) Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.3.0 labels May 10, 2022

Kuznietsov added 4 commits May 10, 2022 18:03

Fixed problems with formatting.

43a2659

Small nit fix.

652e563

Fixed limits.

e2a1c46

Merge branch 'main' into chart_expressions-xy_support_pointseries

b1140dd

VladLasitsa marked this pull request as ready for review May 11, 2022 07:07

VladLasitsa requested review from a team as code owners May 11, 2022 07:07

Kuznietsov approved these changes May 11, 2022

View reviewed changes

botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label May 11, 2022

flash1293 approved these changes May 11, 2022

View reviewed changes

Kuznietsov mentioned this pull request May 11, 2022

[XY] Support vis_dimension type for accessors #129612

Merged

ppisljar approved these changes May 11, 2022

View reviewed changes

mistic approved these changes May 11, 2022

View reviewed changes

VladLasitsa merged commit 640bc62 into elastic:main May 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[XY] Add support of `pointseries` input type #131919

[XY] Add support of `pointseries` input type #131919

VladLasitsa commented May 10, 2022 •

edited by Kuznietsov

Loading

elasticmachine commented May 11, 2022

kibana-ci commented May 11, 2022

API count

Kuznietsov left a comment

flash1293 left a comment

ppisljar left a comment

[XY] Add support of pointseries input type #131919

[XY] Add support of pointseries input type #131919

Conversation

VladLasitsa commented May 10, 2022 • edited by Kuznietsov Loading

Summary

Example:

Features of pointseries to be handled by xyVis in the future:

elasticmachine commented May 11, 2022

kibana-ci commented May 11, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

Kuznietsov left a comment

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

ppisljar left a comment

Choose a reason for hiding this comment

[XY] Add support of `pointseries` input type #131919

[XY] Add support of `pointseries` input type #131919

VladLasitsa commented May 10, 2022 •

edited by Kuznietsov

Loading

Features of `pointseries` to be handled by `xyVis` in the future: