Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data Visualizer] Removing saved object client from file data visualizer #131927

Merged
merged 1 commit into from
May 11, 2022
Merged

[Data Visualizer] Removing saved object client from file data visualizer #131927

merged 1 commit into from
May 11, 2022

Conversation

jgowdyelastic
Copy link
Member

Removing saved object client and using data view client for loading data view titles.

To test, when creating a data view to match the new index, try adding a data view name that already exists.

Fixes #131903

@jgowdyelastic jgowdyelastic added chore non-issue Indicates to automation that a pull request should not appear in the release notes Feature:File and Index Data Viz ML file and index data visualizer v8.3.0 labels May 10, 2022
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner May 10, 2022 14:24
@jgowdyelastic jgowdyelastic self-assigned this May 10, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 536.0KB 535.8KB -229.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@peteharverson peteharverson added the release_note:skip Skip the PR/issue when compiling release notes label May 10, 2022
@qn895
Copy link
Member

qn895 commented May 10, 2022

Tested and LGTM 🎉

peteharverson
peteharverson approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit edb001d into elastic:main May 11, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 11, 2022
@jgowdyelastic jgowdyelastic deleted the removing-saved-object-client-from-file-data-visualizer branch May 11, 2022 14:55
academo pushed a commit to academo/kibana that referenced this pull request May 12, 2022
@jgowdyelastic
[ML] Removing saved object client from file data visualizer (elastic#…
bad27ef 
…131927)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@qn895 qn895 qn895 approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
backport:skip This commit does not require backporting chore Feature:File and Index Data Viz ML file and index data visualizer non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] File data visualizer: Use data views service for loading data views
5 participants
@jgowdyelastic @kibana-ci @qn895 @peteharverson @kibanamachine