Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Improve reporter column in the cases table #132200

Merged
merged 6 commits into from
May 18, 2022
Merged

[Cases] Improve reporter column in the cases table #132200

merged 6 commits into from
May 18, 2022

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented May 15, 2022 •
edited
Loading

Summary

Screenshot 2022-05-15 at 1 37 52 PM

Screenshot 2022-05-15 at 1 38 13 PM

Fixes #110005

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Release note

Reduce space taken by the reporter column in the all cases table.

@cnasikas cnasikas added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.3.0 labels May 15, 2022
@cnasikas cnasikas self-assigned this May 15, 2022
@cnasikas cnasikas added the release_note:skip Skip the PR/issue when compiling release notes label May 15, 2022
@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@cnasikas cnasikas marked this pull request as ready for review May 16, 2022 07:24
@cnasikas cnasikas requested a review from a team as a code owner May 16, 2022 07:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@cnasikas cnasikas requested a review from academo May 16, 2022 07:24
academo
academo reviewed May 16, 2022
View reviewed changes
Copy link
Contributor

@academo academo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add to the description an screenshot of how it looks now?

@cnasikas cnasikas enabled auto-merge (squash) May 16, 2022 07:41
@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

2 similar comments
@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@cnasikas cnasikas requested a review from a team as a code owner May 17, 2022 17:31
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 298.3KB 298.2KB -85.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

MadameSheema
MadameSheema approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and the cypress changes seem correct.

semd
semd approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnasikas cnasikas merged commit 45828f3 into elastic:main May 18, 2022
@cnasikas cnasikas deleted the cases_table_reporter branch May 18, 2022 14:14
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 18, 2022
@cnasikas cnasikas added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels May 27, 2022
This was referenced Jun 6, 2022
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@academo academo academo approved these changes

@MadameSheema MadameSheema MadameSheema approved these changes

@semd semd semd approved these changes

Assignees

@cnasikas cnasikas

Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:enhancement Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RAC] update reporter column in cases list
7 participants
@cnasikas @elasticmachine @kibana-ci @academo @MadameSheema @semd @kibanamachine