Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actionable Observability]130374 use shared execution history table #132245

Merged

Conversation

fkanout
Copy link
Contributor

@fkanout fkanout commented May 16, 2022

Summary

Depends on #130330
Fixes #130374

From triggresActionsUi use the execution history table on the rule details page.

@fkanout
Copy link
Contributor Author

fkanout commented May 17, 2022

@elasticmachine merge upstream

@fkanout fkanout self-assigned this May 17, 2022
@fkanout fkanout added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0 backport:skip This commit does not require backporting labels May 17, 2022
@fkanout fkanout requested a review from a team May 17, 2022 09:11
@fkanout fkanout marked this pull request as ready for review May 17, 2022 11:37
@fkanout fkanout requested a review from a team as a code owner May 17, 2022 11:37
@fkanout fkanout added the release_note:skip Skip the PR/issue when compiling release notes label May 17, 2022
@mgiota
Copy link
Contributor

mgiota commented May 17, 2022

@fkanout I tested it and works fine!

Screenshot 2022-05-17 at 13 47 46

As a suggestion, I would just clean the git history because your PR contains redundant commits. I would do following:

git fetch upstream main
git reset --hard upstream/main
git cherry-pick ea1921834239b7c475e410ae01d477b31dbdda05
git push origin 130374-use-shared-execution-history-table -f

@mgiota mgiota self-requested a review May 17, 2022 11:51
@fkanout fkanout force-pushed the 130374-use-shared-execution-history-table branch from 1e0103e to 0d08181 Compare May 17, 2022 11:57
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
triggersActionsUi 383 384 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 449.8KB 449.8KB +32.0B
Unknown metric groups

API count

id before after diff
triggersActionsUi 397 398 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @fkanout

@fkanout fkanout enabled auto-merge (squash) May 18, 2022 11:38
Copy link
Contributor

@JiaweiWu JiaweiWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fkanout fkanout merged commit 912979a into elastic:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the shared execution history table
4 participants