Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip flaky audit log tests #132510

Merged
merged 1 commit into from
May 19, 2022
Merged

Unskip flaky audit log tests #132510

merged 1 commit into from
May 19, 2022

Conversation

legrego
Copy link
Member

@legrego legrego commented May 19, 2022 •
edited
Loading

Summary

Unskips the flaky audit log tests by introducing a retry mechanism when parsing JSON out of the physical log file.

Resolves #119267

Flaky test runs:

  1. https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/643

400 test executions completed without failures

@legrego legrego added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes v8.3.0 v7.17.4 auto-backport Deprecated - use backport:version if exact versions are needed labels May 19, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego marked this pull request as ready for review May 19, 2022 13:23
@legrego legrego requested a review from a team as a code owner May 19, 2022 13:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

jportner
jportner approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@legrego legrego merged commit d9e6ef3 into elastic:main May 19, 2022
@legrego legrego deleted the security/fix-flaky-audit-test branch May 19, 2022 13:29
kibanamachine pushed a commit that referenced this pull request May 19, 2022
@legrego
Unskip flaky test; Add retry when parsing JSON from audit log (#132510)
2990db8 
(cherry picked from commit d9e6ef3)
@kibanamachine kibanamachine mentioned this pull request May 19, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 19, 2022
@kibanamachine @legrego
Unskip flaky test; Add retry when parsing JSON from audit log (#132510)…
6497607 
… (#132519)

(cherry picked from commit d9e6ef3)

Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.17.4 v8.3.0
Projects
None yet
Milestone
No milestone
5 participants
@legrego @kibana-ci @elasticmachine @kibanamachine @jportner