Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detections] Adds SOM privilege check for Related Integrations #134168

Conversation

spong
Copy link
Member

@spong spong commented Jun 10, 2022

Summary

If SOM privileges are None the Related Integrations feature incorrectly shows all integrations as Not Installed even if some of them may be. This PR adds a client-side privilege check and falls back to the basic UI that just shows the integration name+link and not any install information.

Test instructions:

To test, configure a role with SOM privileges as None, e.g.

Then UI should fall back to no installed information:

Rule Details:

Rule Management:

TODO:

  • A test to exercise this fallback (either unit or cypress w/ specific role should do)
  • Ensure docs mention the required privileges for this feature

Checklist

Delete any items that are not applicable to this PR.

@spong spong added release_note:skip Skip the PR/issue when compiling release notes Feature:Detection Rules Anything related to Security Solution's Detection Rules Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed Feature:Rule Management Security Solution Detection Rule Management Team:Detection Rule Management Security Detection Rule Management Team v8.3.0 Feature:Rule Details Security Solution Detection Rule Details v8.4.0 labels Jun 10, 2022
@spong spong requested a review from a team as a code owner June 10, 2022 22:07
@spong spong self-assigned this Jun 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 10, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / IntegrationDescription Shows total events returned

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 5.2MB 5.2MB +165.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @spong

@banderror banderror self-assigned this Jun 13, 2022
@banderror banderror added bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Detections and Resp Security Detection Response Team labels Jun 13, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@spong
Copy link
Member Author

spong commented Jun 14, 2022

Closing in favor of #134299

@spong spong closed this Jun 14, 2022
@spong spong deleted the related-integrations-adds-fleet-privilege-check branch June 14, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Detection Rules Anything related to Security Solution's Detection Rules Feature:Rule Details Security Solution Detection Rule Details Feature:Rule Management Security Solution Detection Rule Management impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.3.0 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants