Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data views] Create runtime field - use execute api #134713

Merged
merged 11 commits into from
Jun 27, 2022
Merged

[data views] Create runtime field - use execute api #134713

merged 11 commits into from
Jun 27, 2022

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Jun 20, 2022 •
edited
Loading

Summary

Use painless execute api for runtime field value preview. No user facing changes. Reverts #115070 since issues with painless execute api have been resolved via elastic/elasticsearch#85512

@mattkime mattkime changed the title use preview api [data views] Create runtime field - use preview api Jun 25, 2022
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:AppServicesSv labels Jun 25, 2022
@mattkime mattkime marked this pull request as ready for review June 25, 2022 03:47
@mattkime mattkime requested a review from a team as a code owner June 25, 2022 03:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@mattkime mattkime added the release_note:skip Skip the PR/issue when compiling release notes label Jun 25, 2022
@mattkime mattkime changed the title [data views] Create runtime field - use preview api [data views] Create runtime field - use execute api Jun 25, 2022
jloleysens
jloleysens approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Did not test locally.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution / Detection rules, bulk edit should show modal windows when Elastic rules selected and edit only custom rules

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewFieldEditor 148.0KB 147.9KB -25.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataViewFieldEditor 21.8KB 21.7KB -26.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit 637671a into elastic:main Jun 27, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 27, 2022
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request Jun 27, 2022
@mattkime @patrykkopycinski
[data views] Create runtime field - use execute api (elastic#134713)
d0f7eee 
* use preview api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattkime @elasticmachine @kibana-ci @jloleysens @kibanamachine