[Design] Fix ref issue in K7 with field_text #13624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
added
Team:Platform-Design
cjcenizal
pushed a commit
to cjcenizal/kibana
that referenced
this pull request
Aug 26, 2017
cjcenizal
pushed a commit
that referenced
this pull request
Sep 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we are cloning in validatable_control, we need to ensure any previously assigned
ref's are handled. This issue discusses how to do that and this PR applies that behavior.Also added a prop to
KuiFieldTextthat supports providing a ref, but it cannot be calledrefas React considersrefa restricted prop (trying to use results in this warning message)