Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix Dashboard landing page images #137271

Merged
merged 4 commits into from
Jul 27, 2022
Merged

[Security Solution] Fix Dashboard landing page images #137271

merged 4 commits into from
Jul 27, 2022

Conversation

semd
Copy link
Contributor

@semd semd commented Jul 27, 2022 •
edited by kibanamachine
Loading

Summary

Closes #137265

Visual changes only:

  • The overview page image has been updated.
  • The Cloud Security page image distortion has been fixed.
  • The width of the Card links has been updated 362px -> 320px.

Screenshot:

dashboard_landing

@semd semd added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore v8.4.0 labels Jul 27, 2022
@semd semd self-assigned this Jul 27, 2022
@semd
Copy link
Contributor Author

semd commented Jul 27, 2022

@elasticmachine merge upstream

@semd semd marked this pull request as ready for review July 27, 2022 15:09
@semd semd requested a review from a team as a code owner July 27, 2022 15:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@semd semd enabled auto-merge (squash) July 27, 2022 16:14
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3238 3237 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 5.5MB 5.5MB -199.0B
Unknown metric groups

miscellaneous assets size

id before after diff
securitySolution 4.3MB 4.1MB -279.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

@semd semd merged commit a9c1ac9 into elastic:main Jul 27, 2022
@kibanamachine kibanamachine added backport:skip This commit does not require backporting v8.5.0 labels Jul 27, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 27, 2022
@semd
[Security Solution] Fix Dashboard landing page images (elastic#137271)
254d943 
* overview image changed and size fixed

* cloud posture image fixed

* remove unused video svg

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit a9c1ac9)
@kibanamachine kibanamachine mentioned this pull request Jul 27, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 28, 2022
@kibanamachine @semd
[Security Solution] Fix Dashboard landing page images (#137271) (#137314
b2cef82 
)

* overview image changed and size fixed

* cloud posture image fixed

* remove unused video svg

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit a9c1ac9)

Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamster10 jamster10 jamster10 approved these changes

Assignees

@semd semd

Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.4.0 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Fix Overview link image in the Dashboards landing page
5 participants
@semd @elasticmachine @kibana-ci @kibanamachine @jamster10