Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Cases] Removing type field from attachment framework #138676

Merged
merged 2 commits into from
Aug 15, 2022
Merged

[ResponseOps][Cases] Removing type field from attachment framework #138676

merged 2 commits into from
Aug 15, 2022

Conversation

jonathan-buttner
Copy link
Contributor

The type field for EuiCommentProps is being deprecated in this PR: #138351

This PR removes the field from the cases plugin.

@jonathan-buttner jonathan-buttner added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.5.0 labels Aug 11, 2022
@jonathan-buttner jonathan-buttner marked this pull request as ready for review August 15, 2022 12:52
@jonathan-buttner jonathan-buttner requested a review from a team as a code owner August 15, 2022 12:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

peteharverson
peteharverson approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 358.4KB 358.4KB -12.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jonathan-buttner jonathan-buttner merged commit e86cc0c into elastic:main Aug 15, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 15, 2022
@jonathan-buttner jonathan-buttner deleted the cases-remove-comment-type branch August 15, 2022 16:01
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@jonathan-buttner @Mpdreamz
Removing type field (elastic#138676)
99acf62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonathan-buttner @elasticmachine @kibana-ci @peteharverson @kibanamachine