Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] fix scaling and term join in product help popover width #139120

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 18, 2022

elastic/eui#5895 converted EuiText from CSS to Emotion. This change removed max-width: '36em' style from EuiText.

Scaling form and Term join in product help relied on this max-width setting to determine popover width. Without these, popovers look terrible as seen in image below
Screen Shot 2022-08-17 at 9 31 31 AM

Chatted with EUI team about problem and they tried to solve problem in EUI, elastic/eui#6146. However, EUI determined the old behavior was a bug and Maps should set max-width

PR restores original popover look by setting max-width to what was previously set in EuiText CSS.
Screen Shot 2022-08-17 at 9 31 20 AM

To test

  1. install sample web logs data set
  2. create new map
  3. click add layer
  4. add documents layer, select web logs index pattern, click add layer
  5. open popover for scaling and term joins. Verify width is not over sized.

@nreese nreese added release_note:fix [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation backport:skip This commit does not require backporting v8.5.0 labels Aug 18, 2022
@nreese nreese marked this pull request as ready for review August 18, 2022 17:29
@nreese nreese requested a review from a team as a code owner August 18, 2022 17:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.6MB 2.6MB +32.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

code review and tested in chrome

@nreese nreese merged commit 3de69b6 into elastic:main Aug 18, 2022
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Maps release_note:fix v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants