Upgrade screenshotting Chromium and Puppeteer to v15 #140072

vadimkibana · 2022-09-06T10:01:29Z

Summary

Upgrades Puppeteer to v15
Upgrades Chromium build to the latest one with which Puppeteer v15 works
- user-agent: Mozilla/5.0 (X11; Linux aarch64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/105.0.5173.0 Safari/537.36

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

For maintainers

This was checked for breaking API changes and was labeled appropriately

…-fix'

jbudz · 2022-09-07T14:32:53Z

buildkite test this

elasticmachine · 2022-09-08T09:04:45Z

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

vadimkibana · 2022-09-08T09:13:22Z

@elasticmachine merge upstream

x-pack/plugins/screenshotting/server/browsers/chromium/driver.ts

tsullivan · 2022-09-15T18:39:04Z

I pulled some error message text from a debug file by doing the following:

add --enable-logging=headless_shell_debug.log and --v=1 to the args in x-pack/plugins/screenshotting/server/browsers/chromium/driver_factory/args.ts
run a PNG report job
check the headless_shell_debug.log file under x-pack/plugins/screenshotting/chromium/headless_shell-linux_arm64

kibana@6bdf1666479e:~$ grep error x-pack/plugins/screenshotting/chromium/headless_shell-linux_arm64/headless_debug.log
[0915/183613.592250:ERROR:viz_main_impl.cc(186)] Exiting GPU process due to errors during initialization
[0915/183613.611891:ERROR:viz_main_impl.cc(186)] Exiting GPU process due to errors during initialization
[0915/183613.624378:ERROR:viz_main_impl.cc(186)] Exiting GPU process due to errors during initialization
[0915/183613.632936:ERROR:angle_platform_impl.cc(43)] Display.cpp:992 (initialize): ANGLE Display::initialize error 0: Internal Vulkan error (-3): Initialization of an object could not be completed for implementation-specific reasons, in ../../third_party/angle/src/libANGLE/renderer/vulkan/RendererVk.cpp, initialize:1358.
[0915/183613.633057:ERROR:gl_display.cc(506)] EGL Driver message (Critical) eglInitialize: Internal Vulkan error (-3): Initialization of an object could not be completed for implementation-specific reasons, in ../../third_party/angle/src/libANGLE/renderer/vulkan/RendererVk.cpp, initialize:1358.
[0915/183613.633113:ERROR:gl_display.cc(879)] eglInitialize SwANGLE failed with error EGL_NOT_INITIALIZED
[0915/183613.641066:ERROR:viz_main_impl.cc(186)] Exiting GPU process due to errors during initialization

My guess is the build is missing lib dependencies for Vulkan. I plan to update the build script with something similar to lines 227-241 here.

tsullivan

Approving this as the .zip files have been updated with the vulkan libs they need for software rasterization without GPU to work.

jloleysens

Before merging, let's investigate the cloud issue (timing out). I'll take a look probably tomorrow.

jloleysens

I think we should not merge before resolving timeouts on cloud. I'll take a look tomorrow.

streamich · 2022-09-19T08:07:47Z

@elasticmachine merge upstream

vadimkibana · 2022-09-19T09:58:54Z

I've tested it on Ubuntu 20, and can verify that:

It downloads the updated chromium-4440632-locales-linux_x64.zip build.
It generates dashboard print optimized PDF report with page numbers.
It generates dashboard PDF report with page number, but it timed out on my first try.
It generates dashboard PNG report.

vadimkibana · 2022-09-19T09:59:27Z

@elasticmachine merge upstream

vadimkibana · 2022-09-19T10:06:31Z

I think we should not merge before resolving timeouts on cloud. I'll take a look tomorrow.

Do you think cloud timeouts are related to Chromium upgrade, or PDF generation in general? I thought it generates PNG reports consistently, my guess is maybe there is some problem specific to PDFs.

jbudz

Do we know where the extra 20mb added to our distribution size is coming from? I don't want to block merging, but I hope we can circle back on this. Chromium + fonts + pdf + img libs account for about half of Kibana's download size. If we need it all that's fine, I'm just hoping we can double check if there's room for improvement.

tsullivan · 2022-09-20T21:51:45Z

Hi @jbudz for reference, here are the sizes of the bundled binary files for linux.

Sep 15 19:06  272M headless_shell-linux_arm64/headless_shell
Sep 15 18:45  444K headless_shell-linux_arm64/libEGL.so
Sep 15 18:45   14M headless_shell-linux_arm64/libGLESv2.so
Sep 15 18:44   25M headless_shell-linux_arm64/libvk_swiftshader.so
Sep 15 18:45  910K headless_shell-linux_arm64/libvulkan.so.1
Sep 20 11:08   96B headless_shell-linux_arm64/locales
Sep 15 20:17  6.7K headless_shell-linux_arm64/locales/en-US.pak
Sep 15 18:44  107B headless_shell-linux_arm64/vk_swiftshader_icd.json
             
Sep 15 20:50  189M headless_shell-linux_x64/headless_shell
Sep 15 20:30  390K headless_shell-linux_x64/libEGL.so
Sep 15 20:30   13M headless_shell-linux_x64/libGLESv2.so
Sep 15 20:28  6.1M headless_shell-linux_x64/libvk_swiftshader.so
Sep 15 20:29  824K headless_shell-linux_x64/libvulkan.so.1
Sep 20 11:10   96B headless_shell-linux_x64/locales
Sep 15 20:50  6.7K headless_shell-linux_x64/locales/en-US.pak
Sep 15 20:29  107B headless_shell-linux_x64/vk_swiftshader_icd.json

The previous sizes were:

Oct 15  2021  199M headless_shell-linux_arm64/headless_shell
May  5 02:34   96B headless_shell-linux_arm64/locales
May  5 02:34  6.7K headless_shell-linux_arm64/locales/en-US.pak
May  5 02:33  128B headless_shell-linux_arm64/swiftshader
Oct 15  2021  418K headless_shell-linux_arm64/swiftshader/libEGL.so
Oct 15  2021   22M headless_shell-linux_arm64/swiftshader/libGLESv2.so
             
May  5 01:14  145M headless_shell-linux_x64/headless_shell
May  5 01:14   96B headless_shell-linux_x64/locales
May  5 01:14  6.7K headless_shell-linux_x64/locales/en-US.pak
May  5 01:14  128B headless_shell-linux_x64/swiftshader
May  5 01:14  382K headless_shell-linux_x64/swiftshader/libEGL.so
May  5 01:14  3.4M headless_shell-linux_x64/swiftshader/libGLESv2.so

The reason for the replacement of swiftshader with libvulkan appears related to

kibana-ci · 2022-09-22T18:51:49Z

💔 Build Failed

Failed CI Steps

Build and Deploy to Cloud

Metrics [docs]

✅ unchanged

History

💛 Build #73753 was flaky 1f3de01
💚 Build #73693 succeeded 1cba5e7
💚 Build #73263 succeeded c771785
💔 Build #73204 failed 1912e4a
💚 Build #73177 succeeded a62f3f6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tsullivan · 2022-10-12T00:44:09Z

All of the changes related to build-improvement are handled in this PR: #143022

vadimkibana added 8 commits September 6, 2022 11:03

update puppeteer

f15587f

bump linux Chromium builds

a2bc0ab

fix types

9150ca3

get hold of client using public apis

7f726d2

cast to correct object

611b92b

retrieve internal client

76325c7

fix type error

570e967

fix test

cd2bd28

vadimkibana added the ci:cloud-deploy Create or update a Cloud deployment label Sep 6, 2022

kibanamachine and others added 2 commits September 6, 2022 10:27

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

6da819f

…-fix'

increase test tolerance threshold

c204838

vadimkibana added the ci:cloud-redeploy Always create a new Cloud deployment label Sep 7, 2022

empty

ec3cb7d

vadimkibana marked this pull request as ready for review September 8, 2022 09:04

vadimkibana added release_note:skip Skip the PR/issue when compiling release notes Team:AppServicesUx labels Sep 8, 2022

vadimkibana added the v8.5.0 label Sep 8, 2022

vadimkibana changed the title ~~Puppeteer 3~~ Upgrade screenshotting Chromium and Puppeteer to v15 Sep 8, 2022

vadimkibana requested review from jloleysens, tsullivan and dokmic and removed request for jloleysens and tsullivan September 8, 2022 09:12

Merge branch 'main' into puppeteer-3

0fb942d

dokmic reviewed Sep 8, 2022

View reviewed changes

x-pack/plugins/screenshotting/server/browsers/chromium/driver.ts Outdated Show resolved Hide resolved

update jest test

76bc8d4

tsullivan and others added 2 commits September 15, 2022 14:19

Merge branch 'main' into puppeteer-3

2297e8c

bundle the vulkan-swiftshader libs

1596c4b

tsullivan approved these changes Sep 15, 2022

View reviewed changes

tsullivan added the v7.17.7 label Sep 15, 2022

Merge branch 'main' into puppeteer-3

0cddf07

jloleysens reviewed Sep 18, 2022

View reviewed changes

jloleysens requested changes Sep 18, 2022

View reviewed changes

Merge branch 'main' into puppeteer-3

a62f3f6

Merge branch 'main' into puppeteer-3

1912e4a

Merge branch 'main' into puppeteer-3

c771785

tsullivan added 3 commits September 19, 2022 16:32

Merge remote-tracking branch 'elastic/main' into puppeteer-3

89fc815

update yarn for puppeteer

3492387

show the actual chromium release version in dev script

1cba5e7

tsullivan requested a review from a team as a code owner September 19, 2022 23:39

Merge remote-tracking branch 'upstream/main' into puppeteer-3

1f3de01

jbudz reviewed Sep 20, 2022

View reviewed changes

tsullivan mentioned this pull request Sep 20, 2022

Puppeteer 3 #141141

Closed

tsullivan added 2 commits September 22, 2022 11:02

more comments

25ce3fe

Merge remote-tracking branch 'elastic/main' into puppeteer-3

ab87f05

vadimkibana removed the Team:AppServicesUx label Jan 15, 2024

vadimkibana closed this Jan 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade screenshotting Chromium and Puppeteer to v15 #140072

Upgrade screenshotting Chromium and Puppeteer to v15 #140072

vadimkibana commented Sep 6, 2022 •

edited by tsullivan

Loading

jbudz commented Sep 7, 2022

elasticmachine commented Sep 8, 2022

vadimkibana commented Sep 8, 2022

tsullivan commented Sep 15, 2022 •

edited

Loading

tsullivan left a comment

jloleysens left a comment

jloleysens left a comment

streamich commented Sep 19, 2022

vadimkibana commented Sep 19, 2022 •

edited

Loading

vadimkibana commented Sep 19, 2022

vadimkibana commented Sep 19, 2022

jbudz left a comment

tsullivan commented Sep 20, 2022

kibana-ci commented Sep 22, 2022 •

edited

Loading

tsullivan commented Oct 12, 2022

Upgrade screenshotting Chromium and Puppeteer to v15 #140072

Upgrade screenshotting Chromium and Puppeteer to v15 #140072

Conversation

vadimkibana commented Sep 6, 2022 • edited by tsullivan Loading

Summary

Checklist

For maintainers

jbudz commented Sep 7, 2022

elasticmachine commented Sep 8, 2022

vadimkibana commented Sep 8, 2022

tsullivan commented Sep 15, 2022 • edited Loading

tsullivan left a comment

Choose a reason for hiding this comment

jloleysens left a comment

Choose a reason for hiding this comment

jloleysens left a comment

Choose a reason for hiding this comment

streamich commented Sep 19, 2022

vadimkibana commented Sep 19, 2022 • edited Loading

vadimkibana commented Sep 19, 2022

vadimkibana commented Sep 19, 2022

jbudz left a comment

Choose a reason for hiding this comment

tsullivan commented Sep 20, 2022

kibana-ci commented Sep 22, 2022 • edited Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

History

tsullivan commented Oct 12, 2022

vadimkibana commented Sep 6, 2022 •

edited by tsullivan

Loading

tsullivan commented Sep 15, 2022 •

edited

Loading

vadimkibana commented Sep 19, 2022 •

edited

Loading

kibana-ci commented Sep 22, 2022 •

edited

Loading