[Lens] Add bit formatter

[flash1293]

Fixes #139639

adds a basic bit formatter:

Formats a number as bits using numeral.js . Defaults to 0 decimals but it can be formatted.

[elasticmachine]

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

[mbondyra]

Aren't we missing passing it to a child formatter? Bytes and percent are passed for intervals:

bits:

[flash1293]

@mbondyra good catch, I missed that. Should work now. I didn't correctly look up the actual formatter id in all places.

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 8ee991b

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
lens	1.2MB	1.2MB	+571.0B

History

• 💔 Build #74885 failed bb81400
• 💚 Build #74773 succeeded 6152de1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[drewdaemon]

Given the current approach, the metric vis does not add the correct suffix.

It treats the values as regular numbers since it takes its cue as to how to format the value based on the field formatter's ID.

Have we considered adding a "bits" field formatter?

That would allow the metric vis to detect bits values and harness the power of the Intl.NumberFormat API.

[flash1293]

Good call @andrewctate , I thought about it but decided against it as it increases the surface area further (adding a new formatter which, if we follow the existing setup, needs an advanced setting for the default value) and the new metric vis is already rendering almost the same thing as it's doing the kilo, mega, giga abbreviations already (without the "b" suffix, but otherwise it's identical).

All of the approaches feel kind of hacky, but if you think the bits formatter would be preferable I can adjust the PR.

[flash1293]

This is where the default pattern is coming from - if we don't want to introduce a new advanced setting, we would need to adjust this logic which I tried to avoid, but maybe it's worth it:

kibana/src/plugins/field_formats/common/converters/numeral.ts

Line 32 in f1da92e

pattern: this.getConfig!(`format:${this.id}:defaultPattern`),

[drewdaemon]

Discussed the metric vis synchronously. Decided this is fine as is for now. We can always add the proper suffix later if we decided it's worth the hassle of adding a new advanced setting.