Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infrastructure UI] Add network traffic to Hosts table #142137

Merged
merged 3 commits into from
Oct 3, 2022

Conversation

neptunian
Copy link
Contributor

Closes #139316
Screen Shot 2022-09-28 at 1 04 35 PM

Adds Inbound (rx) and outbound (tx) network traffic to the table using the same fields and formulas where we calculate network traffic in Infra. So when viewing the Inventory tx/rx traffic it should be in the same ballpark as these. The formula used is: (average(host.network.ingress.bytes) * 8) / (max(metricset.period) / 1000) and (average(host.network.egress.bytes) * 8) / (max(metricset.period) / 1000). Similar to inventory rx and tx. One addition is multiplying by 8 because Lens formatter assumes bits whereas we add this logic in the formatter. For more information on the formula see #134471

This is easiest reviewed by checking it out. You would need to enable the technical preview in Advanced Settings for the Hosts view. You can also log getLensHostsTable(dataView, query) and paste that into the Lens "Debug in Playground" and save it to view directly in Lens. This requires starting kibana with yarn start --run-examples

@neptunian neptunian added release_note:enhancement Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Sep 28, 2022
@neptunian neptunian requested a review from a team as a code owner September 28, 2022 17:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@weltenwort weltenwort self-requested a review September 29, 2022 12:15
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formula looks good and I was able to correlate the values to the inventory. It's neat to see it translated to lens like this 👏

@neptunian
Copy link
Contributor Author

@elasticmachine merge upstream

@neptunian
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #38 / machine learning - short tests page navigation loads the ML pages

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1023.1KB 1.0MB +3.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@neptunian neptunian merged commit 40b397d into elastic:main Oct 3, 2022
@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Oct 3, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Epic: Host Observability Feature:Metrics UI Metrics UI feature release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infrastructure UI] Add network in/out to Hosts View Table
5 participants