Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Actionable Observability][ResponseOps] Fix time filter in alerts table #142377

Merged
merged 2 commits into from
Oct 3, 2022
Merged

[Actionable Observability][ResponseOps] Fix time filter in alerts table #142377

merged 2 commits into from
Oct 3, 2022

Conversation

maryam-saeidi
Copy link
Member

@maryam-saeidi maryam-saeidi commented Sep 30, 2022 •
edited by kibanamachine
Loading

Fixes #142208

Summary

Fixes issue with passing time filter as is instead of converting it to absolute time range during building es query.

Checklist

@maryam-saeidi maryam-saeidi requested review from a team September 30, 2022 15:28
@maryam-saeidi maryam-saeidi added release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" labels Sep 30, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

XavierM
XavierM approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy fix!

@XavierM XavierM added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.5.0 v8.6.0 labels Sep 30, 2022
jcger
jcger approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@jcger jcger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, everything working now 👏

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 523.6KB 523.6KB +3.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@maryam-saeidi maryam-saeidi merged commit bc65bc5 into elastic:main Oct 3, 2022
@kibanamachine kibanamachine mentioned this pull request Oct 3, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 3, 2022
@maryam-saeidi
Fix time filter in alerts table (elastic#142377)
a2aab45 
(cherry picked from commit bc65bc5)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 3, 2022
@kibanamachine @maryam-saeidi
Fix time filter in alerts table (#142377) (#142459)
eac5a6a 
(cherry picked from commit bc65bc5)

Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
@maryam-saeidi maryam-saeidi mentioned this pull request Oct 5, 2022
Closed
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@maryam-saeidi @WafaaNasr
Fix time filter in alerts table (elastic#142377)
3d181df
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@maryam-saeidi @WafaaNasr
Fix time filter in alerts table (elastic#142377)
847183f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

@jcger jcger jcger approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alerts Table query with time filter update problems
6 participants
@maryam-saeidi @elasticmachine @kibana-ci @kibanamachine @XavierM @jcger