change name guided_onboarding_sample_rule #146062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes rule name "My First Rule"
imays11
added
release_note:skip
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
shashank-elastic
approved these changes
Nov 23, 2022
imays11
deleted the
detection-rules/update-guided-onboarding-rule-name
branch
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 23, 2022
## Summary Changes guided onboarding detection rule name to "My First Rule" CC @approksiu (cherry picked from commit 78a6764)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 23, 2022
# Backport This will backport the following commits from `main` to `8.6`: - [change name guided_onboarding_sample_rule (#146062)](#146062) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Isai","email":"59296946+imays11@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-11-23T17:59:22Z","message":"change name guided_onboarding_sample_rule (#146062)\n\n## Summary\r\n\r\nChanges guided onboarding detection rule name to \"My First Rule\"\r\n\r\nCC @approksiu","sha":"78a67648b53f144d5e47a0f1e290b1f2e7b0e9f7","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.6.0","v8.7.0"],"number":146062,"url":"https://github.com/elastic/kibana/pull/146062","mergeCommit":{"message":"change name guided_onboarding_sample_rule (#146062)\n\n## Summary\r\n\r\nChanges guided onboarding detection rule name to \"My First Rule\"\r\n\r\nCC @approksiu","sha":"78a67648b53f144d5e47a0f1e290b1f2e7b0e9f7"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146062","number":146062,"mergeCommit":{"message":"change name guided_onboarding_sample_rule (#146062)\n\n## Summary\r\n\r\nChanges guided onboarding detection rule name to \"My First Rule\"\r\n\r\nCC @approksiu","sha":"78a67648b53f144d5e47a0f1e290b1f2e7b0e9f7"}}]}] BACKPORT--> Co-authored-by: Isai <59296946+imays11@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes guided onboarding detection rule name to "My First Rule"
CC @approksiu