Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Removing duplicate tooltip text #146308

Merged
merged 1 commit into from
Nov 24, 2022
Merged

[ML] Removing duplicate tooltip text #146308

merged 1 commit into from
Nov 24, 2022

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Nov 24, 2022 •
edited by kibanamachine
Loading

Tooltip sentence was mistakenly repeated.

@jgowdyelastic jgowdyelastic added non-issue Indicates to automation that a pull request should not appear in the release notes :ml Feature:Anomaly Detection ML anomaly detection release_note:skip Skip the PR/issue when compiling release notes v8.6.0 v8.7.0 labels Nov 24, 2022
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner November 24, 2022 15:46
@jgowdyelastic jgowdyelastic self-assigned this Nov 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

pheyos
pheyos approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.4MB 3.4MB -74.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit e05fac1 into elastic:main Nov 24, 2022
@jgowdyelastic jgowdyelastic deleted the fixing-anomaly-details-duplicate-text branch November 24, 2022 17:48
@kibanamachine kibanamachine mentioned this pull request Nov 24, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 24, 2022
@jgowdyelastic
[ML] Removing duplicate tooltip text (elastic#146308)
a124887 
Tooltip sentence was mistakenly repeated.

(cherry picked from commit e05fac1)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 24, 2022
@kibanamachine @jgowdyelastic
[8.6] [ML] Removing duplicate tooltip text (#146308) (#146329)
ae23e97 
# Backport

This will backport the following commits from `main` to `8.6`:
- [[ML] Removing duplicate tooltip text
(#146308)](#146308)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2022-11-24T17:48:31Z","message":"[ML]
Removing duplicate tooltip text (#146308)\n\nTooltip sentence was
mistakenly
repeated.","sha":"e05fac15c619335f60dc143e28a9bb24051edc28","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["non-issue",":ml","Feature:Anomaly
Detection","release_note:skip","v8.6.0","v8.7.0"],"number":146308,"url":"https://github.com/elastic/kibana/pull/146308","mergeCommit":{"message":"[ML]
Removing duplicate tooltip text (#146308)\n\nTooltip sentence was
mistakenly
repeated.","sha":"e05fac15c619335f60dc143e28a9bb24051edc28"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146308","number":146308,"mergeCommit":{"message":"[ML]
Removing duplicate tooltip text (#146308)\n\nTooltip sentence was
mistakenly
repeated.","sha":"e05fac15c619335f60dc143e28a9bb24051edc28"}}]}]
BACKPORT-->

Co-authored-by: James Gowdy <jgowdy@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 28, 2022
@jloleysens
Merge branch 'main' into files-move-components-to-packages-upload-file
9133d24 
* main: (30 commits)
  [Cloud Posture] test latest findings table sort (elastic#144668)
  [api-docs] 2022-11-28 Daily api_docs build (elastic#146359)
  [api-docs] 2022-11-27 Daily api_docs build (elastic#146353)
  [api-docs] 2022-11-26 Daily api_docs build (elastic#146350)
  [DataViews] Fix form validation UX when the same data view name already exists (elastic#146126)
  [Discover] Prevent agg based visualizations of Discover saved objects with adhoc data views (elastic#145583)
  [Health Gateway] Update response aggregation (elastic#145761)
  [api-docs] 2022-11-25 Daily api_docs build (elastic#146341)
  [Metric threshold rule] Adds new context variable for group by keys (elastic#145654)
  [Controls] [Portable Dashboards] Add control group renderer example plugin (elastic#146189)
  Refactor Observability Overview Page (elastic#146182)
  Send complete test data to xMatters, so it can create an alert (elastic#145431)
  [Dashboard] [Controls] Allow options list suggestions to be sorted (elastic#144867)
  Add open API specification for list connector types (elastic#145951)
  skip flaky suite (elastic#146086)
  [ML] Removing duplicate tooltip text (elastic#146308)
  Refactor Rules Page (elastic#146193)
  [DOCS] Alert limit for cases (elastic#145950)
  Extend session index fields mapping with a session creation timestamp. (elastic#145997)
  [Files] Move <Image /> component to `@kbn/shared-ux` package (elastic#145995)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheyos pheyos pheyos approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgowdyelastic @elasticmachine @kibana-ci @kibanamachine @pheyos @peteharverson