Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] [Controls] Load more options list suggestions on scroll #148331

Merged
merged 50 commits into from
Feb 6, 2023
Merged

[Dashboard] [Controls] Load more options list suggestions on scroll #148331

merged 50 commits into from
Feb 6, 2023

Commits on Jan 31, 2023

  1. Add non-functional UI components

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    861b994 View commit details
    Browse the repository at this point in the history

  2. Add cardinality

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    0c74596 View commit details
    Browse the repository at this point in the history

  3. Add rough pagination

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    22580cd View commit details
    Browse the repository at this point in the history

  4. Add page to component state

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    1609cdb View commit details
    Browse the repository at this point in the history

  5. Grab 100 results on page 2 and paginate client-side

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    5511e87 View commit details
    Browse the repository at this point in the history

  6. Update pagination strategy

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    4d8bdd6 View commit details
    Browse the repository at this point in the history

  7. Fix broken suggestions after adding document count

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    b78427b View commit details
    Browse the repository at this point in the history

  8. Remove double linking of keyword/keyword+text fields

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    33587c5 View commit details
    Browse the repository at this point in the history

  9. Fix cardinality

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    83db01d View commit details
    Browse the repository at this point in the history

  10. Reset page on sort change

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    f1911b5 View commit details
    Browse the repository at this point in the history

  11. Load more on scroll rather than through pagination

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    d140942 View commit details
    Browse the repository at this point in the history

  12. First attempt at loading mask

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    6d26bf7 View commit details
    Browse the repository at this point in the history

  13. Make loading state nicer

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    f68a3dd View commit details
    Browse the repository at this point in the history

  14. Add "Reached the end" text

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    9b04b01 View commit details
    Browse the repository at this point in the history

  15. Add tooltip to cardinality badge + replace placeholder text

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    c11f53e View commit details
    Browse the repository at this point in the history

  16. Remove size from component state, simplify logic, and clean up code

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    bec4895 View commit details
    Browse the repository at this point in the history

  17. Test nested queries

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    cbe46f4 View commit details
    Browse the repository at this point in the history

  18. Fix double request by not using debounced load

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    23f9b1a View commit details
    Browse the repository at this point in the history

  19. Fix nested queries

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    ec90a21 View commit details
    Browse the repository at this point in the history

  20. Create cheap vs expensive suggestion aggregation builders

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    0a23660 View commit details
    Browse the repository at this point in the history

  21. Create memoized service for allowExpensive check

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    0122f83 View commit details
    Browse the repository at this point in the history

  22. Add warning when allowExpensive is off

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    28a7dbc View commit details
    Browse the repository at this point in the history

  23. Fix memory leak + better error handling

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    a8a9814 View commit details
    Browse the repository at this point in the history

  24. Close popover on unmount + fatal error

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    4850500 View commit details
    Browse the repository at this point in the history

  25. Fix style of error state

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    d67ed5f View commit details
    Browse the repository at this point in the history

  26. Clean up type guard + styling

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    2905f17 View commit details
    Browse the repository at this point in the history

  27. Treat undefined the same as true

    @kibanamachine @Heenawter
    kibanamachine authored and Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    3680011 View commit details
    Browse the repository at this point in the history

  28. Add unit tests + functional tests

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    3a0ad82 View commit details
    Browse the repository at this point in the history

  29. Fix expensive queries + add unit tests

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    e87194a View commit details
    Browse the repository at this point in the history

  30. Add max options list constant

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    8bf1d0f View commit details
    Browse the repository at this point in the history

  31. Fix logic of expensive queries check + cheap queries

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    cb4c905 View commit details
    Browse the repository at this point in the history

  32. Make allowExpensiveQueries a part of component state instead

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    9345d00 View commit details
    Browse the repository at this point in the history

  33. Clean up and fix flakiness of new tests

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    fe0a21d View commit details
    Browse the repository at this point in the history

  34. Fix accessibility of badges

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    cec4c06 View commit details
    Browse the repository at this point in the history

  35. Update allow_expensive_queries warning tooltip

    @Heenawter
    Heenawter committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    31b2927 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Undo changes to jest_setup and mocks

    @Heenawter
    Heenawter committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    0a12e43 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into add-pagination-to-options-list_2022-12-30

    @kibanamachine
    kibanamachine authored Feb 1, 2023
    Configuration menu
    Copy the full SHA
    6222e32 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Move cardinality + actions to below search bar

    @Heenawter
    Heenawter committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    6b7ab49 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'add-pagination-to-options-list_2022-12-30' of github.co… 

    …m:heenawter/kibana into add-pagination-to-options-list_2022-12-30
    @Heenawter
    Heenawter committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    9d258da View commit details
    Browse the repository at this point in the history

  3. Clean up linting errors

    @Heenawter
    Heenawter committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    eaa32bc View commit details
    Browse the repository at this point in the history

  4. Change location of sorting

    @Heenawter
    Heenawter committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    b87c5bd View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Disable sort button and add tooltip when show only selected

    @Heenawter
    Heenawter committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    3485cb9 View commit details
    Browse the repository at this point in the history

  2. Hide cardinality when allow expensive queries false

    @Heenawter
    Heenawter committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    01b35d5 View commit details
    Browse the repository at this point in the history

  3. Address all feedback except cluster settings

    @Heenawter
    Heenawter committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    6e7d205 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into add-pagination-to-options-list_2022-12-30

    @Heenawter
    Heenawter authored Feb 6, 2023
    Configuration menu
    Copy the full SHA
    88194a1 View commit details
    Browse the repository at this point in the history

  5. Fix typo

    @Heenawter
    Heenawter committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    c366387 View commit details
    Browse the repository at this point in the history

  6. Fix logic of cluster settings route

    @Heenawter
    Heenawter committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    380de4d View commit details
    Browse the repository at this point in the history

  7. Fix grabbing of cardinality text

    @Heenawter
    Heenawter committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    5801d9d View commit details
    Browse the repository at this point in the history

  8. Remove .only

    @Heenawter
    Heenawter committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    7f3f5f7 View commit details
    Browse the repository at this point in the history

  9. Change message for control frame fatal error

    @Heenawter
    Heenawter committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    a78459d View commit details
    Browse the repository at this point in the history