Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] added unit tests on parse package archive logic #150888

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Feb 10, 2023

Summary

Related to #148599
Added unit tests on parse package archive logic

Checklist

@juliaElastic juliaElastic added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Feb 10, 2023
@juliaElastic juliaElastic requested a review from a team as a code owner February 10, 2023 14:19
@juliaElastic juliaElastic self-assigned this Feb 10, 2023
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Feb 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

@hop-dev hop-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@juliaElastic juliaElastic enabled auto-merge (squash) February 10, 2023 15:39
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

@juliaElastic juliaElastic merged commit 3aca0c2 into elastic:main Feb 10, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 10, 2023
## Summary

Related to elastic#148599
Added unit tests on parse package archive logic

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 3aca0c2)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 10, 2023
… (#150908)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Fleet] added unit tests on parse package archive logic
(#150888)](#150888)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Bardi","email":"90178898+juliaElastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-02-10T15:54:27Z","message":"[Fleet]
added unit tests on parse package archive logic (#150888)\n\n##
Summary\r\n\r\nRelated to
https://github.com/elastic/kibana/issues/148599\r\nAdded unit tests on
parse package archive logic\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"3aca0c2212d4caa16d8539e934210849d813aad1","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.8.0"],"number":150888,"url":"https://github.com/elastic/kibana/pull/150888","mergeCommit":{"message":"[Fleet]
added unit tests on parse package archive logic (#150888)\n\n##
Summary\r\n\r\nRelated to
https://github.com/elastic/kibana/issues/148599\r\nAdded unit tests on
parse package archive logic\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"3aca0c2212d4caa16d8539e934210849d813aad1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150888","number":150888,"mergeCommit":{"message":"[Fleet]
added unit tests on parse package archive logic (#150888)\n\n##
Summary\r\n\r\nRelated to
https://github.com/elastic/kibana/issues/148599\r\nAdded unit tests on
parse package archive logic\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"3aca0c2212d4caa16d8539e934210849d813aad1"}}]}]
BACKPORT-->

Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0 v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants