[Dashboard] Scroll to new panel

[cqliu1]

Summary

Closes #97064.
Closes #148922.

This scrolls to a newly added panel on a dashboard instead of remaining at the top. The user can see the new panel without having to manually scroll to the bottom.

This also scrolls to the maximized panel when you minimize instead of just throwing you back to the top of the dashboard.

This scrolling behavior also seems to work with portable dashboards embedded in another apps, but it may require additional work on the consumer to call scrollToPanel in the appropriate callbacks when adding panels.

Scrolls to newly added panel and shows a success border animation

Scrolls to panel on return from editor

Scrolls to panel clone

Scrolling in portable dashboards example

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[andreadelrio]

LGTM. Nice job!

[Heenawter]

Code review + tested locally - everything worked great except for the controls, which currently cause the dashboard to crash (see #152056 (comment)) - will re-review once this is fixed :)

I also noticed that the "scroll to panel" behaviour is a little off for smaller browser sizes - specifically, on smaller vertical browser sizes, the top of the panel gets hidden behind the top nav bar. Not worth holding up this PR though, unless it was a quick fix:

Screen.Recording.2023-04-24.at.8.47.59.AM.mov

[cqliu1]

I also noticed that the "scroll to panel" behaviour is a little off for smaller browser sizes - specifically, on smaller vertical browser sizes, the top of the panel gets hidden behind the top nav bar. Not worth holding up this PR though, unless it was a quick fix:

It looks like this is a side effect of using the block: center scrolling option where it will center the panel on the viewport which includes the space underneath the search/editor bars, so when you have a taller panel, the top could get cut off. I opted for scrolling to the center bc using block: start also resulted in the panel top getting cut off bc it was scrolling to the top of the div which lies under the fixed search/editor bars, so we could need to do an additional scroll to offset the height of the bars. But doing this additional scroll offset would lead the bottom getting cut off when scrolling to the bottom most panels. There just doesn't seem to be a good one size fits all scenario with the scrolling behavior.

If we could someday restore the isolated scrolling to just the dashboard container, we could improve some of the scrolling behavior here.

[Heenawter]

Did another quick test locally + reviewed changes - everything LGTM. Such an exciting and useful feature 🎉 💃 🎉

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 4e16c72
• Cloud Deployment

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
embeddable	442	444	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
controls	187.7KB	187.9KB	+153.0B
dashboard	433.8KB	435.5KB	+1.7KB
total			+1.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
dashboard	38.9KB	39.7KB	+816.0B
embeddable	75.7KB	75.8KB	+91.0B
total			+907.0B

Unknown metric groups

API count

id	before	after	diff
embeddable	544	546	+2

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	17	19	+2
securitySolution	395	398	+3
total			+5

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	18	20	+2
securitySolution	475	478	+3
total			+5

History

• 💚 Build #122609 succeeded 20d1714
• 💔 Build #122565 failed 369aaa4
• 💔 Build #122542 failed d91a587
• 💔 Build #122216 failed 0b93ee8
• 💔 Build #122150 failed 348d5a6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream