-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security solution] Grouping package cleanup #152820
Conversation
…ana into alerts_grouping_package
…ana into alerts_grouping_package
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Summary
An enhancement, a bug fix, and tests for the grouping package
Enhancement: Count aggregation
groupCount0
andunitCount0
.groupsNumber
andalertsCount
grouping.tsx
to show the optional counts at the appropriate timealerts
toevents
Bug fix: reset pagination
activePage: 0
on initial loadpagination
object returned fromuseGrouping
to include areset
function that the consumer can call to setactivePage: 0
pagination.reset()
when the global filters update. Fixes this bug:bug.mov
Tests
reducer.test.ts
use_grouping.test.tsx
use_get_group_selector.test.tsx
To do in follow up