-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[maps] unskip Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/group2/dashboard_maps_by_value·ts #152850
Conversation
…l/apps/dashboard/group2/dashboard_maps_by_value·ts
Pinging @elastic/kibana-presentation (Team:Presentation) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
code review and tested kibana fonts fallback with EMS fonts url blocked
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
…l/apps/dashboard/group2/dashboard_maps_by_value·ts (elastic#152850) Fixes elastic#152476 flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1995 elastic#152396 added an await to map loading that waits for EMS fonts HEAD request. This introduced test flakiness. This PR resolves the issue by re-working the solution from elastic#152476 to not block map loading for EMS fonts HEAD request. Instead, glyphs URL is updated if EMS fonts HEAD request fails after map has loaded. --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…l/apps/dashboard/group2/dashboard_maps_by_value·ts (#152850) Fixes #152476 flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1995 #152396 added an await to map loading that waits for EMS fonts HEAD request. This introduced test flakiness. This PR resolves the issue by re-working the solution from #152476 to not block map loading for EMS fonts HEAD request. Instead, glyphs URL is updated if EMS fonts HEAD request fails after map has loaded. --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Fixes #152476
flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1995
#152396 added an await to map loading that waits for EMS fonts HEAD request. This introduced test flakiness. This PR resolves the issue by re-working the solution from #152476 to not block map loading for EMS fonts HEAD request. Instead, glyphs URL is updated if EMS fonts HEAD request fails after map has loaded.