feat(slo): global and slo specific diagnosis #153118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdelemme
added
release_note:skip
kdelemme
force-pushed
the
feat/slo-diagnosis
branch
2 times, most recently
from
51da694
to
332d509
Compare
kdelemme
force-pushed
the
feat/slo-diagnosis
branch
from
4fd194e
to
3e1bb9e
Compare
kdelemme
changed the title
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @kdelemme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #152503
This PR introduces two new internal routes:
The first one performs a global diagnosis, while the second one focuses on the specific slo.
Testing
Different scenarios:
curl --request GET \ --url http://localhost:5601/kibana/internal/observability/slos/{SLO_ID}/_diagnosis \ --header 'Authorization: Basic ZWxhc3RpYzpjaGFuZ2VtZQ==' \ --header 'kbn-xsrf: oui'Example from slo diagnosis
{ "sloResources": { "slo-observability.sli": "OK", "slo-observability.sli-mappings": "OK", "slo-observability.sli-settings": "OK", "slo-observability.sli.monthly": "OK" }, "sloSavedObject": { "id": "8bc13800-bf53-11ed-87f2-1f84267e6d31", "type": "slo", "namespaces": [ "default" ], "updated_at": "2023-03-10T14:55:06.626Z", "created_at": "2023-03-10T14:55:06.626Z", "version": "WzE5MSwxXQ==", "attributes": { "name": "latency critical", "description": "", "indicator": { "type": "sli.kql.custom", "params": { "index": "service-logs-latency", "filter": "dataset :\"healthy_then_failing\" and host : \"6b6cae72-768f-446f-a1d2-18d54f067e18\"", "good": "latency <= 100", "total": "" } }, "timeWindow": { "duration": "30d", "isRolling": true }, "budgetingMethod": "occurrences", "objective": { "target": 0.98 }, "id": "8bc13800-bf53-11ed-87f2-1f84267e6d31", "settings": { "timestampField": "@timestamp", "syncDelay": "1m", "frequency": "1m" }, "revision": 1, "enabled": true, "createdAt": "2023-03-10T14:55:06.624Z", "updatedAt": "2023-03-10T14:55:06.624Z" }, "references": [], "coreMigrationVersion": "8.0.0" }, "sloTransformStats": { "count": 1, "transforms": [ { "id": "slo-8bc13800-bf53-11ed-87f2-1f84267e6d31-1", "state": "started", "node": { "id": "MZa-zyzzQEGp7jPFm7czTw", "name": "Kevins-MacBook-Pro.local", "ephemeral_id": "AKX0b7A2TP67x0Yik8P07w", "transport_address": "127.0.0.1:9300", "attributes": {} }, "stats": { "pages_processed": 664, "documents_processed": 520125, "documents_indexed": 43345, "documents_deleted": 0, "trigger_count": 145, "index_time_in_ms": 3397, "index_total": 231, "index_failures": 0, "search_time_in_ms": 7033, "search_total": 664, "search_failures": 0, "processing_time_in_ms": 88, "processing_total": 664, "delete_time_in_ms": 0, "exponential_avg_checkpoint_duration_ms": 63.995819400309756, "exponential_avg_documents_indexed": 1.0000000121859232, "exponential_avg_documents_processed": 11.93250807489107 }, "checkpointing": { "last": { "checkpoint": 145, "timestamp_millis": 1678468780920, "time_upper_bound_millis": 1678468680000 }, "operations_behind": 12, "changes_last_detected_at": 1678468780745, "last_search_time": 1678468780745 }, "health": { "status": "green" } } ] }, "dataSample": { "took": 0, "timed_out": false, "_shards": { "total": 1, "successful": 1, "skipped": 0, "failed": 0 }, "hits": { "total": { "value": 10000, "relation": "gte" }, "max_score": null, "hits": [ { "_index": "service-logs-latency", "_id": "E7qJzIYB-ECiHgMAUMrq", "_score": null, "_source": { "@timestamp": "2023-03-10T17:19:56.000Z", "dataset": "95percent_good", "host": "52e34a82-4e33-4154-bca8-fa6e76248078", "latency": 74 }, "sort": [ 1678468796000 ] }, { "_index": "service-logs-latency", "_id": "FLqJzIYB-ECiHgMAUMr7", "_score": null, "_source": { "@timestamp": "2023-03-10T17:19:56.000Z", "dataset": "healthy_then_failing", "host": "6b6cae72-768f-446f-a1d2-18d54f067e18", "latency": 549 }, "sort": [ 1678468796000 ] }, { "_index": "service-logs-latency", "_id": "FbqJzIYB-ECiHgMAUcoA", "_score": null, "_source": { "@timestamp": "2023-03-10T17:19:56.000Z", "dataset": "full_outage_every_day", "host": "cb247dc4-e4a0-4ac7-8838-240ed6bcb801", "latency": 4 }, "sort": [ 1678468796000 ] }, { "_index": "service-logs-latency", "_id": "ELqJzIYB-ECiHgMAPcpQ", "_score": null, "_source": { "@timestamp": "2023-03-10T17:19:51.000Z", "dataset": "95percent_good", "host": "52e34a82-4e33-4154-bca8-fa6e76248078", "latency": 42 }, "sort": [ 1678468791000 ] }, { "_index": "service-logs-latency", "_id": "EbqJzIYB-ECiHgMAPcpZ", "_score": null, "_source": { "@timestamp": "2023-03-10T17:19:51.000Z", "dataset": "healthy_then_failing", "host": "6b6cae72-768f-446f-a1d2-18d54f067e18", "latency": 579 }, "sort": [ 1678468791000 ] } ] } } }